search

symplify / coding-standard

Coding Standard rules for PHP projects with focus on Clean Architecture
MIT License
347 stars 20 forks source link

Make handle @param duplicates and word boundaries correct #21

Closed zonuexe closed 1 year ago

zonuexe commented 1 year ago

resolve https://github.com/symplify/coding-standard/issues/20

zonuexe commented 1 year ago

This comment is a note of a problem I noticed when working on this PR.

The README says that symplify/coding-standard is part of the Symplify monorepo, but it looks like that is no longer the case.

One of the complications in developing symplify/coding-standard is that ECS and symplify/coding-standard are dependent on each other for development.

Since the composer installed version of ECS bundles dependencies, the bundled ones will be preferentially loaded in PHPUnit executed from this project. It confused me that I changed the code and it was not reflected in PHPUnit. Luckily the problem was easily solved by creating a symlink like this:

rm -rf vendor/symplify/easy-coding-standard/vendor/symplify/coding-standard
ln -s $PWD vendor/symplify/easy-coding-standard/vendor/symplify/coding-standard
TomasVotruba commented 1 year ago

Hi, thanks for the fix. I've just confirmed the CI. Could you look at it and fix it? Ideally re-run test and Rector locally, so we have it fixed for sure and can be merged on next check. Thank you :+1:

zonuexe commented 1 year ago

@TomasVotruba This PR is ready. It contains a weird hack to get the tests to run correctly, but CI seems to pass. https://github.com/symplify/coding-standard/pull/21#discussion_r1182950258

TomasVotruba commented 1 year ago

Thank you :clap: