[StandaloneLineConstructorParamFixer] Ignore constructor without arguments

[ruudk]

When you have a constructor without arguments, the fixer changes it to:

-protected function __construct() {
+protected function __construct(
+) {

Not sure how to solve this. Any advice?

[TomasVotruba]

I'd skip the ) as following token or get arguments count and skip if === 0.

[TomasVotruba]

I'd skip the ) as following token or get arguments count and skip if === 0.

[ruudk]

While running this test locally, I notice that my changes in src/Fixer/Spacing/StandaloneLineConstructorParamFixer.php are not used.

Upon running it with Xdebug, I notice that the tests use this file:

vendor/symplify/easy-coding-standard/vendor/symplify/coding-standard/src/Fixer/Spacing/StandaloneLineConstructorParamFixer.php

Is there a developer contributing guideline that I'm missing?

I checked out the repo, ran composer install, and ran the tests. I expected it to use the code in src but apparently it uses the scoped vendor code in vendor/symplify/easy-coding-standard/vendor/.

[ruudk]

@TomasVotruba I think I found a way to solve it. Could you approve the workflow?

[ruudk]

@TomasVotruba Please approve again. Why is there approval needed?

[TomasVotruba]

That's Github default for first-contributors. Do you know how to turn it off?

[TomasVotruba]

Thanks for the fix 👍

[ruudk]

Thanks for the hint and the merge. Please tag it 💙

[TomasVotruba]

Expect next week