symplify / monorepo-builder

Composer tools to maintain a monorepo
https://www.tomasvotruba.cz/blog/2019/02/18/how-we-automated-shopsys-packages-release-from-2-days-to-1-console-command/
MIT License
451 stars 39 forks source link

monorepo-builder merge does not remove unused packages #34

Closed TMFHokies closed 1 year ago

TMFHokies commented 1 year ago

Hi all,

My team is adopting monorepo-builder to merge manyrepos into a monorepo. However, I noticed that monorepo-builder merge does not remove unused packages from the main composer.json. So consider this scenario, there are two packages — monorepo/a and monorepo/b — in the monorepo. Only monorepo/a specifies monolog/monolog. Then I run:

cd packages/a
composer remove monolog/monolog
cd -
monorepo-builder merge

However, after those commands monolog/monolog still exists in the main composer.json but not packages/a/composer.json.

Do I have the workflow wrong, or is this intended behavior?

Thanks for your help!

kayw-geek commented 1 year ago

At present, this is the expected behavior. Thank you.

TMFHokies commented 1 year ago

Thanks for the response!

At present, this is the expected behavior. Thank you.

Would you mind helping me understand why?

TMFHokies commented 9 months ago

Thanks for the response!

At present, this is the expected behavior. Thank you.

Would you mind helping me understand why?

@kayw-geek Sorry to bring up an old thread, but did you happen to see the question above?

Thanks for a great tool!

kayw-geek commented 9 months ago

Thanks for the response!

At present, this is the expected behavior. Thank you.

Would you mind helping me understand why?

@kayw-geek Sorry to bring up an old thread, but did you happen to see the question above?

Thanks for a great tool!

Sorry, I don't know the reason, That may be for the author to answer.