search

sympmarc / SPServices

SPServices is a jQuery library which abstracts SharePoint's Web Services and makes them easier to use. It also includes functions which use the various Web Service operations to provide more useful (and cool) capabilities. It works entirely client side and requires no server install.
MIT License
208 stars 61 forks source link

jquery.SPServices.d.ts is incomplete #23

Closed kbatman37 closed 6 years ago

kbatman37 commented 8 years ago

The TypeScript definition file found in jquery.SPServices.d.ts appears to be incomplete and defines only SPCascadeDropdowns.

sympmarc commented 8 years ago

That's correct. @johnnliu gave it a start. Feel free to build upon that and contribute back.

johnnliu commented 8 years ago

I also defined the default $().SPServices() method, which is arguably the big method that everyone uses...

I agree it's incomplete, for example, I'd like to add SPXmlToJson etc.

lirichard commented 6 years ago

Bit late to the party, but I worked on fleshing out the TypeScript definitions quite a bit; the results so far are on my fork of this repo, branch ts-definitions (link to the file). I'm pretty new to TS as well as SPServices, so a grain or several of salt is probably appropriate. Would love to get this pulled and updated at some point though.

More changes to come, but I would appreciate if some folks more experienced with the library could take a look and advise on anything that looks terribly wrong!

sympmarc commented 6 years ago

@lirichard Thanks a lot for the effort you've put in here! Sorry for the delay in looking at this. @juliemturner and I are taking a look and we'll probably add your changes soon. If you've done any more and can submit a pull request, even better.

juliemturner commented 6 years ago

@lirichard if you want to submit a pull request I'll look at the changes you made, pretty hard to do that comparison in your fork. Thanks

lirichard commented 6 years ago

Created pull request!

juliemturner commented 6 years ago

Merge accepted. Thanks for your hard work on this.