sympodius / org-novelist

Org Novelist is a system for writing novel-length fiction using Emacs Org mode.
GNU General Public License v3.0
183 stars 14 forks source link

Errors when running commands #2

Closed chuckberrypi closed 1 year ago

chuckberrypi commented 1 year ago

Just giving this library a spin after seeing it on reddit. I like the concept a lot, but I'm getting a few errors that are keeping me from actually using it. Whenever I try a org-novelist-new-* function, the index buffer opens, but instead of a new heading for the new thing, there's an error message that just says "Cannot move past superior level or buffer limit."

sympodius commented 1 year ago

Hi again!

Hmm... I can only find one part of the code that might produce this error, but I can't reproduce it myself under normal usage conditions. Can you let me know which version of Emacs you are using and give me a list of steps to reproduce the error? Thanks!

chuckberrypi commented 1 year ago

Hi! I'm using emacs 28.2. I'm not sure what to say in terms of steps I took to reproduce the error. I cloned this repository, ran load-file to install the functions, then ran org-novelist-new-story and entered a name and location. I got the error I discussed in the pull request, which said that mapconcat was called with the wrong number of arguments (2). I added nil as a third argument, which let the new story function run, but then had these issues with all of the new functions.

boj commented 1 year ago

Hello,

Neat project! I'm experiencing a similar problem.

Unfortunately, running any org-novelist-new-{chapter,character,etc} command results in the error "Cannot move past superior level or buffer limit". It results in an empty org block * at the top of Indices/chapters.org (under your default heading) and nothing else created as far as I can tell.

Happy to help debug this further. Let me know what you need.

sympodius commented 1 year ago

Hmm. I still don't really know what's causing this, but I'll be releasing an update either today or tomorrow that will hopefully address some other issues I've found. Perhaps it will help.

I don't use Doom Emacs, so it's never been tested on that. Possibly that's the problem. I'll keep looking into it.

sympodius commented 1 year ago

I think I've fixed this now.

It's possibly been caused by Doom Emacs 28 running Org version 9.6.1. As far as I can tell, one of the built-in Org functions I was using previously (org-insert-heading-after-current) doesn't have the same behaviour in Doom Emacs 28 as it does in vanilla Emacs 28. This may be down to the newer version of Org being used by Doom, but I'm not sure.

In any case, I'm now using a different built-in Org function (org-insert-heading-respect-contents). It appears to do exactly what I want, so it was just a case of swapping out one for the other. Had I realized this function existed, I might have coded some other things differently in Org Novelist, but I'll leave that for a future refactor. For now, I'm hoping this allows Doom Emacs 28 users to work with Org Novelist.

Let me know how you get on. I've updated the main branch with the fix.

boj commented 1 year ago

That fixed it! Sorry you had to go through all that trouble. Sincerely appreciate this workflow and all of your effort building it.

sympodius commented 1 year ago

No problem at all 🙂 I'm just glad more people get to use Org Novelist. Thanks for the bug report. I would never have thought to check Doom Emacs if you hadn't pointed the way 🙂

chuckberrypi commented 1 year ago

Same, it's working for me too! Thanks a lot for this neat package and tracking down this issue!