search

sympy / planet.sympy.org

Legacy repository. Use https://github.com/sympy/planet-sympy and https://github.com/planet-sympy/planet.sympy.org instead
Other
9 stars 27 forks source link

Favicon wasn't copied to gh-pages branch #23

Closed debugger22 closed 10 years ago

debugger22 commented 10 years ago

I added sympy_favicon.png to master but it wasn't copied to gh-pages while updating.

https://github.com/sympy/planet.sympy.org/pull/22

certik commented 10 years ago

Looks like this script (https://github.com/sympy/planet.sympy.org/blob/master/update) needs to be updated to also copy the newly added image.

debugger22 commented 10 years ago

I think just adding images/* at Line 21 will do, right?

debugger22 commented 10 years ago

Why don't we just replace it with git add .?

certik commented 10 years ago

It think git add images and git add images/* is equivalent. It adds everything under this directory. So the bug is somewhere else.

As to git add., we want to avoid adding these sources into the gh-branch, that's why only the generated files are added.

asmeurer commented 10 years ago

You should use git add -A, which will also track deletions (if you run a git add without that flag in a recent version of git, it will give you a deprecation warning about this).

debugger22 commented 10 years ago

@asmeurer will that also solve the issue we are discussing?

asmeurer commented 10 years ago

No idea. Just thought I would toss it out there :)