sympy / planet.sympy.org

Legacy repository. Use https://github.com/sympy/planet-sympy and https://github.com/planet-sympy/planet.sympy.org instead
Other
9 stars 27 forks source link

Add favicon file to config.ini #25

Closed debugger22 closed 10 years ago

debugger22 commented 10 years ago

Completes https://github.com/sympy/planet.sympy.org/pull/24

debugger22 commented 10 years ago

@asmeurer

debugger22 commented 10 years ago

@certik Can this be merged now?

certik commented 10 years ago

I think so, but I'll let @asmeurer merge it, so that I don't have to revert it again.

debugger22 commented 10 years ago

Oh! :smile:

asmeurer commented 10 years ago

Did you make the favicon full resolution again?

certik commented 10 years ago

I reverted it, see the other PR for commit hashes.

Sent from my mobile phone. On Apr 28, 2014 6:35 PM, "Aaron Meurer" notifications@github.com wrote:

Did you make the favicon full resolution again?

— Reply to this email directly or view it on GitHubhttps://github.com/sympy/planet.sympy.org/pull/25#issuecomment-41630944 .

asmeurer commented 10 years ago

It's not reverted in this pull request, and I just checked and it's still low resolution in my browser (although browsers do tend to cache favicons pretty heavily).

certik commented 10 years ago

This PR is against master where it's reverted.

Sent from my mobile phone. On Apr 28, 2014 6:42 PM, "Aaron Meurer" notifications@github.com wrote:

It's not reverted in this pull request, and I just checked and it's still low resolution in my browser (although browsers do tend to cache favicons pretty heavily).

— Reply to this email directly or view it on GitHubhttps://github.com/sympy/planet.sympy.org/pull/25#issuecomment-41631309 .

asmeurer commented 10 years ago

OK

debugger22 commented 10 years ago

Image size is already 64X64

debugger22 commented 10 years ago

Favicon won't be visible without changing config.ini for which I've created this PR. What you are seeing is just the cached version.

debugger22 commented 10 years ago

@asmeurer ping!