search

sympy / sympy-bot-old

SymPy pull request helper
http://reviews.sympy.org/
Other
24 stars 16 forks source link

List all PRs and get the master_commit from the PR by default #134

Closed jrioux closed 12 years ago

jrioux commented 12 years ago

List all pull requests instead of only the first 30.

By default, determine the master commit based on the target of the pull request, thus obtaining accurate mergeable status.

asmeurer commented 12 years ago

I attempted to rewrite the code so that the default of -m was the commit that the pull request is against, and not master, but I found it to be a non-trivial change. Glad to see you figured it out.

IMHO, "master_commit" should be renamed to "merge_commit".

jrioux commented 12 years ago

I actually don`t know if it works with a repo different from sympy/sympy. How could we test it out?

asmeurer commented 12 years ago

-R other/repo

jrioux commented 12 years ago

It works quite nicely by specifying e.g. -R mattpap/sympy (no need to specify -m): https://github.com/mattpap/sympy/pull/3

asmeurer commented 12 years ago

OK, I'm merging this then.