search

sympy / sympy-bot-old

SymPy pull request helper
http://reviews.sympy.org/
Other
24 stars 16 forks source link

Refactor how multiple reports are generated. #136

Closed jrioux closed 11 years ago

jrioux commented 11 years ago

In case of merge conflicts: Abort trying to build the docs, upload only one merge conflict report instead of one per interpreter, and write a short to-the-point summary.

In case of an unfetchable branch: Similar, but no report necessary.

The diff for this looks worse than it actually is because of indentation: I had to wrap the tests in a if block. One can nicely see the meaningful changes with git diff -b.

asmeurer commented 11 years ago

Or https://github.com/sympy/sympy-bot/pull/136/files?w=1

asmeurer commented 11 years ago

That didn't work. I mean add "?w=1" to the end of the URL of the diff.

jrioux commented 11 years ago

I'll merge this in 24h if there are no more comments.

asmeurer commented 11 years ago

I didn't get a chance to review this, but I'm +1 if it works.

asmeurer commented 11 years ago

Actually, I just did test it, and it works. I didn't test fetch, but I'll assume that it works too.