SymPy bot does not recognize when a "pull request" is really an issue

sympy / sympy-bot-old

SymPy pull request helper

http://reviews.sympy.org/

Other

24 stars 16 forks source link

SymPy bot does not recognize when a "pull request" is really an issue #143

Closed asmeurer closed 11 years ago

asmeurer commented 11 years ago

If you try sympy-bot review 1733, it will just hang, because https://github.com/sympy/sympy/issues/1733 is an issue that someone opened.

asmeurer commented 11 years ago

And by "hang", I mean that it will just do

Could not get pull request 1733, retrying in 1 seconds...
Could not get pull request 1733, retrying in 2 seconds...
Could not get pull request 1733, retrying in 4 seconds...
Could not get pull request 1733, retrying in 8 seconds...
Could not get pull request 1733, retrying in 16 seconds...

forever

asmeurer commented 11 years ago

I've got a fix for this, but my rate limit got exceeded in testing it, so I'll wait until tomorrow to make sure it really works and then submit a pull request.

asmeurer commented 11 years ago

So I've used some magic (actually, hub), and turned this issue into a pull request. Please review.

asmeurer commented 11 years ago

Be careful testing sympy-bot list. You might run exceed your API limit (see #147).