search

sympy / sympy-bot-old

SymPy pull request helper
http://reviews.sympy.org/
Other
24 stars 16 forks source link

Maintain offline record of author info #154

Closed vramana closed 9 years ago

vramana commented 11 years ago

To reduce number of API requests as mentioned #147 an offline record author info which contains author's name and email is created. author_info is written in JSON.

asmeurer commented 11 years ago

Don't track the author_info file with git. It would be better to save it to .sympy with the other configuration data.

vramana commented 11 years ago

Okay. I understand that we have to maintain sympy-bot.conf in .sympy But why author_info ? I am fine with either way but I just want to know is there anything specific which made you say like this.

asmeurer commented 11 years ago

I just think it's a better place to put the file.

As for why it shouldn't be tracked, you don't track files that are going to change with git.

vramana commented 11 years ago

Ah. Sorry I forgot about that. I will change this.