search

sympy / sympy-bot-old

SymPy pull request helper
http://reviews.sympy.org/
Other
24 stars 16 forks source link

Make use of labels in the pull requests #73

Open asmeurer opened 12 years ago

asmeurer commented 12 years ago

Now that I've enabled the issues for pull requests (https://github.com/sympy/sympy/issues), we should make use of the labels. Some idea:

vperic commented 12 years ago

On Tue, Nov 29, 2011 at 6:16 PM, Aaron Meurer reply@reply.github.com wrote:

Now that I've enabled the issues for pull requests (https://github.com/sympy/sympy/issues), we should make use of the labels.  Some idea:

  • I've created the label "Needs Better Patch".  When this is present, SymPy-Bot should add a note to the summary reminding that it is there, so that people don't accidentally merge (and also to remind the person who made the request).

This is a good idea.

  • We should create labels for use by SymPy-Bot, like "Failed Python 3", "Passed Python 2.7", "Can't be merged" etc., and automatically add them/modify them on pull requests when reviewing them. This will be especially useful when we have fully automated testing, since we will be able to have that information completely at any given time, and then it will be easiest to sort through things on GitHub.

This is an even better idea! Of course, it should be robust enough from the sympy-bot side (though I guess we can always override it if there's a mistake), but it'd be really useful. It could also lower the amount of "spam" produced by SymPy (ie. if everything is ok, it might as well just put in the label and that's it).

  • Any other ideas?

I don't know, perhaps we could have a "DoNotMerge" tag or something that people can put on requests that they are submitting only for discussion, or for works in progress (eg. the recent plotting work by @stefan-krastanov, I think @smichr also submitted a pull request that's meant mostly for discussion or for reference). If we have clear tags like you mention above, then there's really no way we can "spam" the pull request system. Other than that, I'm out of ideas.

Reply to this email directly or view it on GitHub: https://github.com/sympy/sympy-bot/issues/73

Vladimir Perić

asmeurer commented 12 years ago

Feel free to make those other ones. This issue is mainly just for automatic labels for SymPy-bot.

We can also have (manual) labels for code in, and we can add milestones to track pull requests before a release.

vperic commented 12 years ago

On Tue, Nov 29, 2011 at 8:36 PM, Aaron Meurer reply@reply.github.com wrote:

Feel free to make those other ones. This issue is mainly just for automatic labels for SymPy-bot.

We can also have (manual) labels for code in, and we can add milestones to track pull requests before a release.

Reply to this email directly or view it on GitHub: https://github.com/sympy/sympy-bot/issues/73#issuecomment-2943710

Oh right, I just noticed this is a sympy-bot issue (which I was subscribed to automatically) and not a mail to the SymPy mailing list. I'll see about making some labels, a GCI one would be a good idea.

Vladimir Perić