search

sympy / sympy-bot-old

SymPy pull request helper
http://reviews.sympy.org/
Other
24 stars 16 forks source link

Fix printing of custom interpreter path #83

Closed flacjacket closed 12 years ago

flacjacket commented 12 years ago

Even when sympy-bot is run with a custom interpreter, it uses the path of the current executable in creating the text of the comment, see [1] which was run with 2.5 but printed the path of the 2.7 executable. This slightly changes my output, as now the default lists /usr/bin/python instead of /usr/bin/python2.7 (which is still correct, and the version printing makes up for any ambiguity), but it fixes the output when using -i python2.5 so that it prints /usr/bin/python2.5. To see the effect of this fix, see [2].

I have only tested this with linux and can really only guarantee it works for me, so any other testing would be greatly appreciated. It can be quickly checked by adding the -n flag to not upload and setting the test command to do a fast test, like -t 'bin/test sympy/physics/quantum/tests/test_constants.py', then looking at what is listed as the Interpreter in the command line output.

[1] https://github.com/sympy/sympy/pull/874#issuecomment-3334831 [2] https://github.com/sympy/sympy/pull/908#issuecomment-3335785

certik commented 12 years ago

I see. Thanks for the fix! I can't test this on the Mac, so I am merging it, and if it doesn't work for Aaron, we'll fix it later.

asmeurer commented 12 years ago

It still gets the architecture wrong.