search

sympy / sympy-bot-old

SymPy pull request helper
http://reviews.sympy.org/
Other
24 stars 16 forks source link

Can't use sympy-bot upon windows XP #85

Closed goodok closed 11 years ago

goodok commented 12 years ago

Can't use sympy-bot upon windows XP

asmeurer commented 12 years ago

What happens when you try to run it? Is it just an issue of correctly using os.path.join?

goodok commented 12 years ago

It is related with the lines like 'cmd ("cd %s; git clone ...")' that is when a few commands run as one line. In windows XP the separator must be strictly "&&", not ";". I supposed that "&&" is still valid for OS X too.

I have changed this lines on my win machine, and it became workable for this machine. But I have not tested this branch in linux yet. I will test and publish it tomorrow (A tree fell on my sister's car and broke the rear window)

asmeurer commented 12 years ago

&& is not only valid in UNIX, but it is better, as it will prevent execution of the second command if the first fails.

goodok commented 12 years ago

See pull request: https://github.com/sympy/sympy-bot/pull/86

vramana commented 11 years ago

@asmeurer I think you can close this issue as you have closed #86