search

sympy / sympy-bot

GitHub bot for SymPy
https://github.com/sympy-bot
Other
22 stars 11 forks source link

Release notes entry for patches against release branch #58

Closed sidhantnagpal closed 5 years ago

sidhantnagpal commented 5 years ago

It looks like the patches made against the release branch, will have their release notes entry added to the wiki page of the next release (and not the current release). This came to my attention in https://github.com/sympy/sympy/pull/16408.

For the patch https://github.com/sympy/sympy/pull/16408 (made against the 1.4 branch) the bot says that "This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5".

asmeurer commented 5 years ago

The bot should be getting the version from the release file in the base branch of the PR. I'll have to investigate why this is wrong.

If that PR is merged in the meantime please correct the wiki.

asmeurer commented 5 years ago

Oh actually looking more closely at the code maybe it's not actually doing that. The contents_url is just based on the repo, which I guess uses the default branch.

asmeurer commented 5 years ago

https://github.com/sympy/sympy/pull/16408 is showing the right URL now. We can double check when it is merged that it goes in the right file.