search

sympy / sympy-bot

GitHub bot for SymPy
https://github.com/sympy-bot
Other
22 stars 11 forks source link

Comment about files that are added or deleted #77

Closed asmeurer closed 4 years ago

asmeurer commented 4 years ago

https://github.com/sympy/sympy-bot/issues/75

For now it just comments. But we could easily add functionality where someone with push access has to @mention the bot and whitelist files.

This is what this looks like https://github.com/asmeurer/GitHub-Issues-Test/pull/44#issuecomment-586520029

asmeurer commented 4 years ago

I will need to fix the webapp tests for this, but I want to get feedback if it is a good idea first.

asmeurer commented 4 years ago

This is ready to go for a basic test run. This is what the comments would look like https://github.com/asmeurer/GitHub-Issues-Test/pull/44#issuecomment-587146125. For now, it's purely informational. It doesn't currently set any failing status if there are added or deleted files. It also automatically deletes the comment if you force push and remove the offending commits.

I would suggest merging this as-is and getting feedback from the community on if it's a good idea and how it can be improved.

oscarbenjamin commented 4 years ago

Yeah, looks good to me. Let's see how it works out in practice.