search

sympy / sympy-bot

GitHub bot for SymPy
https://github.com/sympy-bot
Other
22 stars 11 forks source link

Recognize co-authored-by in commit messages #85

Open asmeurer opened 4 years ago

asmeurer commented 4 years ago

See for example https://github.com/sympy/sympy/pull/19158

iammosespaulr commented 4 years ago

https://github.com/sympy/sympy-bot/blob/c600efc24edc6c74fa0837fa5f556dd0aa64f13f/sympy_bot/webapp.py#L82-L91

Searching message in https://github.com/sympy/sympy-bot/blob/c600efc24edc6c74fa0837fa5f556dd0aa64f13f/sympy_bot/webapp.py#L85 for Co-authored-by: author-name <name@xxx.com> using regex and adding them to users might work ?

asmeurer commented 4 years ago

It would be better if there were direct support for it in the GitHub API. The reason is that we need a GitHub username for the release notes.

iammosespaulr commented 4 years ago

It would be better if there were direct support for it in the GitHub API. The reason is that we need a GitHub username for the release notes.

Yeah it would! I can't seem to find support for it in the Official API's. However, https://api.github.com/search/users?q=iammosespaulr@gmail.com does provide the username.

asmeurer commented 4 years ago

So we can query the email. If we don't get a username from it, we can just include the name and email directly (it doesn't have to be a username, that's just the format we use).