search

sympy / sympy-bot

GitHub bot for SymPy
https://github.com/sympy-bot
Other
22 stars 11 forks source link

Use the same comment for release notes and file added checks #90

Open sylee957 opened 4 years ago

sylee957 commented 4 years ago

https://github.com/sympy/sympy/pull/19708

asmeurer commented 4 years ago

I don't see it. I see one comment for the release notes and one for the added files. Was there a comment that was deleted?

sylee957 commented 4 years ago

Okay, I didn’t know that another comment is added for file deleting.

asmeurer commented 4 years ago

We could merge them into one comment. I just did a separate comment to make it clear that they are separate checks, but maybe it would be cleaner as a single comment.

asmeurer commented 4 years ago

That would also be better for seeing the history, since currently it deletes the file added comment if the commits are rebased and the added files are removed. But if it were in the same comment, you could still see it in the comment edit history.