search

sympy / sympy-paper

Repo for the paper "SymPy: symbolic computing in python"
https://peerj.com/articles/cs-103/
Other
47 stars 37 forks source link

Pull request reviewing assignments #43

Open asmeurer opened 8 years ago

asmeurer commented 8 years ago

Now that the writing assignments are in, we need to get them reviewed and merged. The deadline for this is Monday, April 18. By that day, all pull requests should be merged, so that we have a complete "first draft" of the paper.

In order to do this, everyone will be assigned a different pull request to review. Feel free to also review other pull requests as well, but each person assigned below should have the responsibility to get that PR merged by Monday (in addition to their own PR, obviously).

Here are reviewing assignments. I know some PRs are lengthier than others, so if it's too much for you in this time frame let me know.

Me: I will review https://github.com/sympy/sympy-paper/pull/34. I also need to write an introduction to the paper.

@fredrik-johansson: please review https://github.com/sympy/sympy-paper/pull/38

@aktech and @hargup: please review https://github.com/sympy/sympy-paper/pull/29 and https://github.com/sympy/sympy-paper/pull/31

@Sumith1896: please review https://github.com/sympy/sympy-paper/pull/42.

@moorepants: please review https://github.com/sympy/sympy-paper/pull/21 and https://github.com/sympy/sympy-paper/pull/35

@ashutoshsaboo: please review https://github.com/sympy/sympy-paper/pull/37

@scopatz: please review https://github.com/sympy/sympy-paper/pull/41

@Upabjojr: please review https://github.com/sympy/sympy-paper/pull/36

@shivamvats and @leosartaj: please review https://github.com/sympy/sympy-paper/pull/33

moorepants commented 8 years ago

Why not just merge them all as is, so we can see the paper in its entirety? It is very hard to see the flow of the paper, see the theme, and see what things are duplicated, etc. I'd much rather just merge them all as is so that we can review the whole paper.

asmeurer commented 8 years ago

That's why we need to have this done by Monday :)

My thinking there was that many of the pull requests already have comments on them, which aren't addressed. If we merge them now, it will be harder to keep track of what needs to be done (it's also harder to do review on code that is already merged).

After Monday, we will all go through the whole paper and do more revisions.

Sorry, I should have made that clearer initially.

asmeurer commented 8 years ago

With that being said, feel free to manage your review however you want, as long as it gets done.

hargup commented 8 years ago

Sorry for being late here, I just opened up a pull request on sets https://github.com/sympy/sympy-paper/pull/45, please add it in the list somewhere.

asmeurer commented 8 years ago

I've kept groups together, so I guess it would go to @ashutoshsaboo. It would make sense for you and @aktech should review each other's work as well.

certik commented 8 years ago

@isuruf and @thilinarmtb would also like to get involved. For now you can review some of the PRs above, and I'll see if there is more stuff to write up. Maybe @asmeurer or others can have some suggestions. I think #30 has some ideas.

Sumith1896 commented 8 years ago

Great! We can have a section of future plans and goals and mention a sentence or two about SymEngine. This PR https://github.com/sympy/sympy/pull/11002 puts great light on the road ahead.

ashutoshsaboo commented 8 years ago

@asmeurer :+1: I'll review both #45 and #37 ! :smiley:

asmeurer commented 8 years ago

I only assigned people who submitted writing, but extra help from others (especially reviewing help) is welcome. If you want to write something, it would be great to get some content on polynomials, integration algorithms, and matrices.

asmeurer commented 8 years ago

@Sumith1896, maybe add that to https://github.com/sympy/sympy-paper/pull/31.