sympy / sympy

A computer algebra system written in pure Python
https://sympy.org/
Other
12.49k stars 4.32k forks source link

Prevent RecursionError in nc_simplify for floating point coefficients #26557

Closed rrodenbusch closed 1 month ago

rrodenbusch commented 1 month ago

References to other Issues or PRs

Fixes #26556

Brief description of what is fixed or changed

Allow simplification of expressions with floating point coefficients for non-commutative symbols

Other comments

Release Notes

sympy-bot commented 1 month ago

:white_check_mark:

Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13.

Click here to see the pull request description that was parsed. #### References to other Issues or PRs Fixes #26556 #### Brief description of what is fixed or changed Allow simplification of expressions with floating point coefficients for non-commutative symbols #### Other comments #### Release Notes * simplify * Prevent RecursionError when simplifying expressions with floating-point coefficients on a non-commutative symbol

**Update** The release notes on the [wiki](https://github.com/sympy/sympy/wiki/Release-Notes-for-1.13) have been updated.

oscarbenjamin commented 1 month ago

Don't worry about the failing mpmath tests (https://github.com/mpmath/mpmath/issues/704#issuecomment-2085301825)

oscarbenjamin commented 1 month ago

Looks good. Thanks!

rrodenbusch commented 1 month ago

I will submit the documentation changes in another PR. Maybe we can help those who follow avoid the mistake I made.

On Tue, Apr 30, 2024, 15:31 Oscar Benjamin @.***> wrote:

@.**** commented on this pull request.

In .mailmap https://github.com/sympy/sympy/pull/26557#discussion_r1585492219:

@@ -1616,6 +1616,7 @@ richierichrawr @.> rimibis @.> risubaba @.> ritikBhandari @.> +rrodenbusch @.***>

In the new PR you won't have the problems because you are already in the .mailmap file (unless you change your git config...).

— Reply to this email directly, view it on GitHub https://github.com/sympy/sympy/pull/26557#discussion_r1585492219, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3FKCYJ6BVP4PTKSB2X4WDY775RXAVCNFSM6AAAAABHAJZSS6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZSGQ3DMOJVHA . You are receiving this because you authored the thread.Message ID: @.***>