Add benchmarks for cholesky_solve and is_positive_definite

sympy / sympy_benchmarks

Some benchmarks of SymPy

14 stars 32 forks source link

Closed oscarbenjamin closed 4 years ago

oscarbenjamin commented 4 years ago

These benchmarks give better coverage of the performance regression identified in https://github.com/sympy/sympy/issues/19200

oscarbenjamin commented 4 years ago

It seems like the tests haven't run on this PR and I'm not sure why...

moorepants commented 4 years ago

LGTM! Thanks.

moorepants commented 4 years ago

I've had trouble with Travis's connection to Github (the key) disappearing on my repos and I have to re-establish the connection.

moorepants commented 4 years ago

@asmeurer Could check the settings on this repo to see if the Travis key is still there.

oscarbenjamin commented 4 years ago

I pushed a couple of bigger benchmarks and the tests ran this time round. Thanks for reviewing!