Open LukasMoll opened 1 year ago
This is good. Thanks. You'll need to also enable a flake8 check in the CI.
This is good. Thanks. You'll need to also enable a flake8 check in the CI.
Thanks for the feedback. I copied and modified the runtests.yml file from the sympy project. I modified this file to only contain the instructions for flake8 for this project. I can add the others (ruff, mypy) in the future.
What is the purpose of having mypy? I don't quite see how that is relevant for a set of benchmarks.
What is the purpose of having mypy? I don't quite see how that is relevant for a set of benchmarks.
I think it's nice to have to catch type related bugs and to enforce some code conventions.
Example error it's showing now:
benchmarks/solve.py:19: error: Name "expr" already defined on line 7 [no-redef]
Not sure what the purpose is of expr = None
but I think I can remove it.
I understand that it can be more annoying then useful, I'll remove mypy.
My preference is to remove mypy.
I think that __init__.py
from logic-inputs
should be removed. That looks like some abuse
I think that init.py from logic-inputs should be removed. That looks like some abuse
Thanks.