search

sympy / sympy_benchmarks

Some benchmarks of SymPy
14 stars 32 forks source link

[Do Not Merge] Duplicate PR #91

Closed 1e9abhi1e10 closed 1 year ago

1e9abhi1e10 commented 1 year ago

duplicate PR of #78

1e9abhi1e10 commented 1 year ago

@oscarbenjamin In this PR the added benchmark doesn't running in CI.

oscarbenjamin commented 1 year ago

@brocksam should we expect that new benchmarks added in a PR will run in CI for the PR?

I'm not sure exactly what this does: https://github.com/sympy/sympy_benchmarks/blob/5563b6dd9266d7d9bc87f2c306cc68d7d566a8d4/.github/workflows/run-benchmarks.yml#L29-L34 My guess is that uses the sympy_benchmarks master branch rather than the PR branch.

brocksam commented 1 year ago

@brocksam should we expect that new benchmarks added in a PR will run in CI for the PR?

I agree this is the behaviour that want, but as evidenced above clearly isn't the case right now.

I'm not sure exactly what this does:

https://github.com/sympy/sympy_benchmarks/blob/5563b6dd9266d7d9bc87f2c306cc68d7d566a8d4/.github/workflows/run-benchmarks.yml#L29-L34

My guess is that uses the sympy_benchmarks master branch rather than the PR branch.

Agreed, I've opened PR #92 for this.