Add benchmarks for GCD when input is Gaussian Integer

1e9abhi1e10 commented 1 year ago

This PR adds the benchmarks for the subresultants PRS method. Related Issue: https://github.com/sympy/sympy_benchmarks/issues/88

See https://github.com/sympy/sympy/pull/25442

1e9abhi1e10 commented 1 year ago

@oscarbenjamin These errors occurs, Do We need to change these?

asv run --config asv.conf.actions.json
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/[3](https://github.com/sympy/sympy_benchmarks/actions/runs/5982262043/job/16231134344?pr=97#step:6:3).10.12/x6[4](https://github.com/sympy/sympy_benchmarks/actions/runs/5982262043/job/16231134344?pr=97#step:6:4)
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.12/x[6](https://github.com/sympy/sympy_benchmarks/actions/runs/5982262043/job/16231134344?pr=97#step:6:6)4/lib
Couldn't load asv.plugins.mamba because
No module named 'mamba'
Couldn't load asv.plugins.virtualenv because
No module named 'packaging'
· Unknown environment type 'virtualenv'
· No environments selected
Error: Process completed with exit code 1.

oscarbenjamin commented 1 year ago

These errors occurs, Do We need to change these?

This is because of the new asv release. I'm not sure if this is fixed now.

oscarbenjamin commented 1 year ago

Looks like it still fails.

oscarbenjamin commented 1 year ago

The domain should just be returned by the make_poly function like:

return f, g, d, syms, ZZ

oscarbenjamin commented 1 year ago

Why is x being passed here: https://github.com/sympy/sympy_benchmarks/blob/6aac3803151a3b667224a52d2be93a60030dc91c/benchmarks/polys.py#L325

sympy / sympy_benchmarks

Add benchmarks for GCD when input is Gaussian Integer #97