Closed aktech closed 4 years ago
Is going straight to 1.6 too much work?
Do we know what the test coverage is like for Gamma? Can we rely on the test suite or do we need to do a lot of manual testing as well?
Is going straight to 1.6 too much work?
It seems there isn't. I thought there might be, so took the conservative approach. There was only a tokenisation change, I have upgraded it to 1.6
now.
Do we know what the test coverage is like for Gamma? Can we rely on the test suite or do we need to do a lot of manual testing as well?
We don't know a number as of yet, as most of the tests except a few unit tests, runs via casperjs and I am not sure how to get coverage from it (I'll create an issue for it).
I have mostly relied on those tests and some manual tests. The casperjs tests seems to test most of the complex functionalities like matrices, integration, differentiation and their steps, which I have tested manually (not the correctness, as it obviously depends on SymPy).
@asmeurer any other concerns?
No concerns here, though I didn't test it.
We should figure out how to automate the SymPy updating, so that it doesn't get out of date. Can we use one of those services that sends PRs when there are updates in your requirements.txt?
We should figure out how to automate the SymPy updating, so that it doesn't get out of date. Can we use one of those services that sends PRs when there are updates in your requirements.txt?
Yes, we can do that via Github's Dependbot. It seems I don't have permission to integrate it, I have sent a request to add dependbot, you should have probably received it.
I'll merge this in next 48 hours if no objections.
is_Integer
attr before accessing (due to MutableDenseMatrix has no attribute is_Integer)sympy.parsing.sympy_tokenize
->tokenize
Fixes #155