sympy / sympy_gamma

A SymPy version of WolframAlpha.
https://sympygamma.com
Other
674 stars 112 forks source link

Upgrade SymPy to 1.6 #159

Closed aktech closed 4 years ago

aktech commented 4 years ago

Fixes #155

asmeurer commented 4 years ago

Is going straight to 1.6 too much work?

asmeurer commented 4 years ago

Do we know what the test coverage is like for Gamma? Can we rely on the test suite or do we need to do a lot of manual testing as well?

aktech commented 4 years ago

Is going straight to 1.6 too much work?

It seems there isn't. I thought there might be, so took the conservative approach. There was only a tokenisation change, I have upgraded it to 1.6 now.

Do we know what the test coverage is like for Gamma? Can we rely on the test suite or do we need to do a lot of manual testing as well?

We don't know a number as of yet, as most of the tests except a few unit tests, runs via casperjs and I am not sure how to get coverage from it (I'll create an issue for it).

I have mostly relied on those tests and some manual tests. The casperjs tests seems to test most of the complex functionalities like matrices, integration, differentiation and their steps, which I have tested manually (not the correctness, as it obviously depends on SymPy).

https://github.com/sympy/sympy_gamma/blob/e4d4523a3afa3d12867513644201006d2fb964c1/app/test/test_phantomjs.js#L30-L89

aktech commented 4 years ago

@asmeurer any other concerns?

asmeurer commented 4 years ago

No concerns here, though I didn't test it.

We should figure out how to automate the SymPy updating, so that it doesn't get out of date. Can we use one of those services that sends PRs when there are updates in your requirements.txt?

aktech commented 4 years ago

We should figure out how to automate the SymPy updating, so that it doesn't get out of date. Can we use one of those services that sends PRs when there are updates in your requirements.txt?

Yes, we can do that via Github's Dependbot. It seems I don't have permission to integrate it, I have sent a request to add dependbot, you should have probably received it.

aktech commented 4 years ago

I'll merge this in next 48 hours if no objections.