search

synac-chat / synac-legacy

Some IRC-like chat application that might become good one day
11 stars 1 forks source link

Should I also ban IPs which banned users try to log into, or only the IP they had at the time? #9

Closed jD91mZM2 closed 6 years ago

ttofis commented 6 years ago

I say we should do this like Minecraft, being user bans are different than ip bans. So when you ban a user, no ip is banned with him. If now the server owner wants to ban his ip, that's ok too, but it should be a completely different thing.

jD91mZM2 commented 6 years ago

I'd say that makes an annoying amount of flags and commands, but I don't know

ttofis commented 6 years ago

Why though? What did you have planned? Banning an ip to equal to ban users trying to log from it forever too? That just seems more work. Vote Thumbs up or down on my previous comment.

jD91mZM2 commented 6 years ago

Yes but I need a BanUser and BanIP packet

ttofis commented 6 years ago

yeah, although you could get them into one Ban packet and just have a boolean stating if it is an ip or not (so user).

jD91mZM2 commented 6 years ago

True but the client needs /ban and /ban-ip which do the exact same thing, only differently. Also the server owners needs access to the users' IP.

Unless we do the simple way: A text file where each line is an IP. The server owner may add one and it will be effective immediately. Also log more stuff (like IP) to the server console

ttofis commented 6 years ago

Logging is something EXTREMELY needed by the server console

Anyways, I agree that's a nice way to solve it

jD91mZM2 commented 6 years ago

Alright: Vote up or down for ban file. It does require SSHing into the host machine which is annoying.

ttofis commented 6 years ago

All other solutions I gave require SSHing too.. So I guess that's good enough

jD91mZM2 commented 6 years ago

Even if your idea got a lot of upvotes, this issue itself is not really relevant to the idea. I think banning IPs a banned user tries to log in as is a pretty bad idea, and I suspect you do too. Plus your idea is completely against automatic IP banning, which only makes my suspicion more believable.

ttofis commented 6 years ago

I clearly stated that I believe. Exactly, I find the idea of automatic IP banning awful.

jD91mZM2 commented 6 years ago

How about we just ban creation of accounts from banned IPs? (Which is what we're doing currently after the #4 fix)

ttofis commented 6 years ago

Ehm, well, can you even send a login package if the ip is banned? Oh wait, this has to also do with the other git issue...

jD91mZM2 commented 6 years ago

Yeah. But tbodt suggested you can use the firewall to ban IPs you don't trust.

ttofis commented 6 years ago

I find firewalls sketchy and I feel it will seem like a missing feature more than anything.

jD91mZM2 commented 6 years ago

Yes but firewalls disallow it for all programs, not just synac.