Allow <Text /> nodes to be used and translated in template field values

synacor / preact-i18n

Simple localization for Preact.

BSD 3-Clause "New" or "Revised" License

205 stars 18 forks source link

Allow <Text /> nodes to be used and translated in template field values #30

Closed billneff79 closed 5 years ago

billneff79 commented 5 years ago

resolves issue #29

Built size goes from 1365 bytes to 1402 bytes (+37 bytes)

billneff79 commented 5 years ago

@pl12133 can you take a look at this one?

billneff79 commented 5 years ago

@pl12133 I put a comment on your other branch. I think it is a neat feature, but needs a few changes to be ready for prime-time: https://github.com/synacor/preact-i18n/commit/97d56bddc925e9efd522128d43139ca138d32c72#r31870940

pl12133 commented 5 years ago

@billneff79 Thanks for taking a look, I think this feature is ready to go as-is and if we want to add fields support for withText than can be a separate issue.