search

synacor / preact-i18n

Simple localization for Preact.
BSD 3-Clause "New" or "Revised" License
205 stars 18 forks source link

Use rollup babel #6

Closed Fridus closed 7 years ago

Fridus commented 7 years ago

Use babel in tests and build with the same configuration.

Fridus commented 7 years ago

@developit Hi ! Could you check this PR asap ? This PR fix usage of withText https://github.com/synacor/preact-i18n/issues/5 I need this fix quickly for one of my projects :)

billneff79 commented 7 years ago

Looking at it now. I can merge the PR, but I think only @developit has the rights to push a new package to npm, and he's on vacation right now. I'll see if I can flag him down.

billneff79 commented 7 years ago

gzipped bundle size grew by 38% with this change. investigating

billneff79 commented 7 years ago

seems like the size diff is mostly related to the es2015 plugin for babel creating polyfills for some things that buble does not, such as typeof and it is a little bigger for creating a class

billneff79 commented 7 years ago

if we are going to use babel instead of buble (which I'm fine with), then we can also get rid of the assign ponyfill in /lib/utils

billneff79 commented 7 years ago

Closing this one and will merge my minor adjustments in PR #7