Closed trajan0x closed 2 weeks ago
The chain_queue.go
file underwent a refactoring to replace errgroup.Group
with sync.WaitGroup
across various methods. This change enhances the management of goroutines and simplifies error handling. Specifically, the chainQueue
, chainPendingQueue
, bumpTX
, and updateOldTxStatuses
methods were updated to implement sync.WaitGroup
for improved concurrency control.
File | Change Summary |
---|---|
ethergo/.../chain_queue.go | Replaced errgroup.Group with sync.WaitGroup for improved concurrency handling across methods: chainQueue , chainPendingQueue , bumpTX , and updateOldTxStatuses . |
With WaitGroups set, the code did weave,
A chain of tasks, now clear, concieve.
Syncing threads in harmony strong,
No errgroup chaos, we belong.
Transactions bump, statuses renew,
In concurrency’s light, we found our cue. 🚀
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 25.63185%. Comparing base (
28499ba
) to head (d1e08ec
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@coderabbitai review
Latest commit: |
d1e08ec
|
Status: | ✅ Deploy successful! |
Preview URL: | https://9b2dfe06.sanguine-fe.pages.dev |
Branch Preview URL: | https://fix-rfq-arb-hotfix.sanguine-fe.pages.dev |
Description
Summary by CodeRabbit
errgroup.Group
withsync.WaitGroup
for better performance and reliability.