Closed trajan0x closed 3 months ago
[!WARNING]
Rate limit exceeded
@trajan0x has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 22 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 5ed6d9a306afa89a55e9768a3a1054e4b6147227 and 5c4554a47c71aac917075adc1a8501baed9dbc85.
The updates focus on adding functionality for handling and testing token withdrawals within the RFQ relayer service. This includes updates to the handler logic, configuration enhancements, test additions, and command-line interface updates to support withdrawal operations. Specific changes include new helper functions, structs, and tests interacting with blockchain backends, as well as refined configurations for token ID handling and whitelisting.
File(s) | Summary |
---|---|
services/rfq/relayer/relapi/handler.go |
Added fields and helper functions for token withdrawals, updated handler logic, and modified imports. |
services/rfq/relayer/relapi/server_test.go |
Added Ethereum and ERC20 token withdrawal test functions, updated imports. |
contrib/opbot/config/config.go |
Updated comments for SignozBaseURL and RelayerURLS fields. |
ethergo/submitter/submitter.go |
Updated meterName constant, added Address() method to TransactionSubmitter interface. |
services/rfq/relayer/cmd/cmd.go |
Included new withdrawCommand in CLI commands. |
services/rfq/relayer/cmd/commands.go |
Added flags and logic for withdrawal commands, updated imports. |
services/rfq/relayer/relapi/export_test.go |
Introduced TokenIDExists function for testing configuration token existence. |
services/rfq/relayer/relapi/suite_test.go |
Added setup for withdrawal tests, mock token ID, and deployment management logic. |
services/rfq/relayer/relconfig/config.go |
Added fields for API withdrawals and white listing, introduced DecodeTokenID function. |
services/rfq/relayer/relconfig/config_test.go |
Added tests for DecodeTokenID function. |
sequenceDiagram
participant User
participant CLI
participant Handler
participant Config
participant Submitter
participant Blockchain
User->>CLI: Initiate withdrawal command
CLI->>Handler: Process withdrawal command
Handler->>Config: Validate token ID and address
Config->>Handler: Return validation status
Handler->>Submitter: Submit transaction
Submitter->>Blockchain: Interact with blockchain for withdrawal
Blockchain->>Submitter: Return transaction status
Submitter->>Handler: Provide transaction result
Handler->>User: Return withdrawal outcome
In code's vast land, where tokens roam, Withdrawals dance, away from home. From handler's care to tests that sing, A rabbit's joy in every string. With configs set and functions new, The blockchain whispers, "Thank you!"!
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 52.63158%
with 90 lines
in your changes missing coverage. Please review.
Project coverage is 25.73801%. Comparing base (
9cdc208
) to head (5c4554a
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Add a withdrawal api to rfq
To do:
Future work:
Summary by CodeRabbit
New Features
Bug Fixes
Tests
Documentation