search

synapsecns / sanguine

Synapse Monorepo
MIT License
35 stars 27 forks source link

feat(withdrawal): print txhash of withdrawal #2845

Closed golangisfun123 closed 2 weeks ago

golangisfun123 commented 2 weeks ago

Description A clear and concise description of the features you're adding in this pull request.

Additional context Add any other context about the problem you're solving.

Metadata

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The updates streamline dependencies across modules, primarily focusing on switching assertion and color libraries. There's a notable enhancement in the relapi package, introducing methods for transaction hash retrieval by nonce, involving new route definitions and handlers. Import statements in multiple files are reorganized to improve maintainability. The .vscode/settings.json adjusts formatting settings, and additional indirect dependencies are added to services/rfq to support new features.

Changes

File / Path Change Summary
agents/go.mod Removed dependencies on github.com/alecthomas/colour and github.com/alecthomas/repr.
core/go.mod Added dependencies: github.com/alecthomas/assert, github.com/alecthomas/colour, repr.
core/metrics/base.go Reorganized import statements and removed redundant net/http import.
core/metrics/metrics.go Consolidated imports: Added net/http, os, strings.
core/metrics/metrics_test.go Switched from github.com/stretchr/testify/assert to github.com/alecthomas/assert.
services/explorer/go.mod Removed dependencies on github.com/alecthomas/colour and github.com/alecthomas/repr.
services/rfq/go.mod Added new indirect dependencies to support features (e.g., charmbracelet, coninput).
.../rfq/relayer/cmd/commands.go Changed chainID handling, added spinner for transaction status, changed to big.Int.
.../rfq/relayer/relapi/client.go Introduced GetTxHashByNonce method for RelayerClient interface and its implementation.
.../rfq/relayer/relapi/handler.go Added GetTxHashByNonce function to Handler for retrieving transaction hash by nonce.
.../rfq/relayer/relapi/server.go Added route getTxHashByNonceRoute and handler registration for GetTxHashByNonce.
.../rfq/relayer/relapi/client_test.go Added test functions (TestEthWithdraw, TestERC20Withdraw, etc.) for withdrawals and getting TX hashes.
services/scribe/go.mod Removed github.com/alecthomas/assert dependency.
.vscode/settings.json Commented out editor.formatOnSave setting.
.../cctp-relayer/go.mod Removed dependencies on github.com/alecthomas/assert, colour, repr.
.../cctp-relayer/relayer/util_test.go Switched assert library import to github.com/stretchr/testify/assert.
.../rfq/relayer/relconfig/config_test.go Changed assert import to github.com/stretchr/testify/assert.

Poem

In lines of code where features bloom,
We changed dependencies for room,
Imports shuffled, colors bright,
Functions gleam in summer's light.
Spinners spin, TX hashes gleam,
Optimize for the rabbit's dream.
✨🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 18.82845% with 194 lines in your changes missing coverage. Please review.

Project coverage is 25.35979%. Comparing base (e401a73) to head (4c475e9). Report is 4 commits behind head on master.

Files Patch % Lines
ethergo/listener/otel.go 22.95082% 43 Missing and 4 partials :warning:
services/rfq/relayer/service/otel.go 0.00000% 33 Missing :warning:
services/rfq/relayer/service/relayer.go 0.00000% 31 Missing :warning:
services/rfq/relayer/cmd/commands.go 0.00000% 26 Missing :warning:
services/rfq/relayer/reldb/base/quote.go 0.00000% 22 Missing :warning:
services/rfq/relayer/service/chainindexer.go 0.00000% 13 Missing :warning:
services/rfq/relayer/relapi/handler.go 50.00000% 9 Missing and 3 partials :warning:
ethergo/listener/listener.go 33.33333% 3 Missing and 1 partial :warning:
services/cctp-relayer/relayer/relayer.go 50.00000% 2 Missing and 1 partial :warning:
services/rfq/relayer/relapi/client.go 81.25000% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2845 +/- ## =================================================== - Coverage 25.65579% 25.35979% -0.29600% =================================================== Files 768 785 +17 Lines 55239 56491 +1252 Branches 80 80 =================================================== + Hits 14172 14326 +154 - Misses 39594 40687 +1093 - Partials 1473 1478 +5 ``` | [Flag](https://app.codecov.io/gh/synapsecns/sanguine/pull/2845/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | Coverage Δ | | |---|---|---| | [cctp-relayer](https://app.codecov.io/gh/synapsecns/sanguine/pull/2845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `31.97848% <50.00000%> (+0.04068%)` | :arrow_up: | | [core](https://app.codecov.io/gh/synapsecns/sanguine/pull/2845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `59.20382% <ø> (ø)` | | | [ethergo](https://app.codecov.io/gh/synapsecns/sanguine/pull/2845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `48.05942% <23.88060%> (+0.05834%)` | :arrow_up: | | [explorer](https://app.codecov.io/gh/synapsecns/sanguine/pull/2845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `4.97877% <ø> (ø)` | | | [git-changes-action](https://app.codecov.io/gh/synapsecns/sanguine/pull/2845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `23.69615% <ø> (ø)` | | | [omnirpc](https://app.codecov.io/gh/synapsecns/sanguine/pull/2845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `33.23904% <ø> (ø)` | | | [opbot](https://app.codecov.io/gh/synapsecns/sanguine/pull/2845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `0.18564% <ø> (ø)` | | | [promexporter](https://app.codecov.io/gh/synapsecns/sanguine/pull/2845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `8.50242% <ø> (?)` | | | [rfq](https://app.codecov.io/gh/synapsecns/sanguine/pull/2845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `24.80315% <15.66265%> (-0.14043%)` | :arrow_down: | | [screener-api](https://app.codecov.io/gh/synapsecns/sanguine/pull/2845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `29.29293% <ø> (-0.50506%)` | :arrow_down: | | [scribe](https://app.codecov.io/gh/synapsecns/sanguine/pull/2845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `18.11159% <ø> (-0.06438%)` | :arrow_down: | | [tools](https://app.codecov.io/gh/synapsecns/sanguine/pull/2845/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `30.55118% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cloudflare-pages[bot] commented 2 weeks ago

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4c475e9
Status: ✅  Deploy successful!
Preview URL: https://77a91e9f.sanguine-fe.pages.dev
Branch Preview URL: https://withdrawal-print.sanguine-fe.pages.dev

View logs