search

synapsecns / sanguine

Synapse Monorepo
MIT License
38 stars 29 forks source link

[rfq] metrics, hotfixes #2854

Closed trajan0x closed 3 months ago

trajan0x commented 3 months ago

[goreleaser]

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent changes integrate OpenTelemetry metrics recording into the ethergo/listener package through a new otelRecorder type and adjust concurrency handling in the Relayer service by switching from TryAcquire to Acquire with a context parameter. Error messages and error handling have also been refined in various parts.

Changes

File(s) Change Summary
ethergo/listener/listener.go Added otelRecorder to chainListener, initialized it in NewChainListener, and recorded metrics in doPoll.
services/rfq/relayer/service/relayer.go Updated semaphore logic to use Acquire method with context parameter for better concurrency control.
ethergo/listener/otel.go Introduced otelRecorder type with fields and methods for metrics tracking using OpenTelemetry.
services/rfq/relayer/service/chainindexer.go Added defer statement in runChainIndexer to reset err to nil if it isn't nil.
services/rfq/relayer/reldb/base/quote.go Updated error message in UpdateQuoteRequestStatus to use specific error type reldb.ErrNoQuoteForID.

Poem

Changes in the code do chime,
Metrics trace the block’s rhyme. 🕰️
Semaphore now guards the way,
No more Try, context does sway.
Errors caught, specifics gleam,
In a world where data streams. 🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 19.51220% with 66 lines in your changes missing coverage. Please review.

Project coverage is 25.38243%. Comparing base (31b5f8f) to head (60b0cf1).

Files Patch % Lines
ethergo/listener/otel.go 22.95082% 43 Missing and 4 partials :warning:
services/rfq/relayer/service/chainindexer.go 0.00000% 13 Missing :warning:
ethergo/listener/listener.go 33.33333% 3 Missing and 1 partial :warning:
services/rfq/relayer/reldb/base/quote.go 0.00000% 1 Missing :warning:
services/rfq/relayer/service/relayer.go 0.00000% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2854 +/- ## =================================================== - Coverage 25.65982% 25.38243% -0.27740% =================================================== Files 768 784 +16 Lines 55242 56350 +1108 Branches 80 80 =================================================== + Hits 14175 14303 +128 - Misses 39594 40572 +978 - Partials 1473 1475 +2 ``` | [Flag](https://app.codecov.io/gh/synapsecns/sanguine/pull/2854/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | Coverage Δ | | |---|---|---| | [agents](https://app.codecov.io/gh/synapsecns/sanguine/pull/2854/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `34.31953% <ø> (+0.11095%)` | :arrow_up: | | [cctp-relayer](https://app.codecov.io/gh/synapsecns/sanguine/pull/2854/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `31.97848% <ø> (ø)` | | | [ethergo](https://app.codecov.io/gh/synapsecns/sanguine/pull/2854/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `48.04604% <23.88060%> (+0.04495%)` | :arrow_up: | | [explorer](https://app.codecov.io/gh/synapsecns/sanguine/pull/2854/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `4.97877% <ø> (ø)` | | | [omnirpc](https://app.codecov.io/gh/synapsecns/sanguine/pull/2854/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `33.23904% <ø> (ø)` | | | [opbot](https://app.codecov.io/gh/synapsecns/sanguine/pull/2854/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `0.18564% <ø> (ø)` | | | [promexporter](https://app.codecov.io/gh/synapsecns/sanguine/pull/2854/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `8.50242% <ø> (?)` | | | [rfq](https://app.codecov.io/gh/synapsecns/sanguine/pull/2854/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `24.91545% <0.00000%> (-0.05231%)` | :arrow_down: | | [scribe](https://app.codecov.io/gh/synapsecns/sanguine/pull/2854/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `18.11159% <ø> (-0.06438%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cloudflare-workers-and-pages[bot] commented 3 months ago

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4afaee1
Status:🚫  Build failed.

View logs