Closed trajan0x closed 2 weeks ago
The changes mainly involve updating the statusCounts
map and the RecordStatusCount
method to use the reldb.QuoteRequestStatus
type instead of int
. This adjustment ensures better type safety and consistency across the handling of quote request statuses. Updates apply to function signatures, method calls, and type conversions related to status handling.
File Path | Change Summary |
---|---|
services/rfq/relayer/service/otel.go |
Updated statusCounts map and RecordStatusCount method to use reldb.QuoteRequestStatus type instead of int . |
services/rfq/relayer/service/otel_generated.go |
Modified RecordStatusCount in the iOtelRecorder interface to accept reldb.QuoteRequestStatus instead of int . |
services/rfq/relayer/service/relayer.go |
Changed the argument in RecordStatusCount method calls from int(status.Int()) to status . |
In the code where maps reside,
Status updates now glide,
From integers to types refined,
Errors and bugs left behind.
Metrics flow with greater grace,
In a more consistent space.
ππ Hooray for progress in our place!
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Latest commit: |
4716a8e
|
Status: | β Deploy successful! |
Preview URL: | https://8bec215a.sanguine-fe.pages.dev |
Branch Preview URL: | https://fix-string-status.sanguine-fe.pages.dev |
Attention: Patch coverage is 0%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 25.64509%. Comparing base (
a554e13
) to head (4716a8e
).
Files | Patch % | Lines |
---|---|---|
services/rfq/relayer/service/otel.go | 0.00000% | 5 Missing :warning: |
services/rfq/relayer/service/relayer.go | 0.00000% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
makes status less confusing
Summary by CodeRabbit
int
.