search

synapsecns / sanguine

Synapse Monorepo
MIT License
43 stars 31 forks source link

[wip] feat(synapse-interface): display input commas #3095

Closed bigboydiamonds closed 3 months ago

bigboydiamonds commented 3 months ago

Summary by CodeRabbit

These changes collectively improve the overall user experience by ensuring that large numbers are easier to read and understand.

6d89607d9c7ea7d2664f37016ce573ba16765bb7: synapse-interface preview link

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes introduce a new utility function, formatNumberWithCommas, which formats numeric strings by adding commas as thousand separators. This function is utilized in the AmountInput component to improve the display of numerical values and in the StateManagedBridge component to enhance toast messages. The updates aim to improve the readability of numerical information presented to users across the application.

Changes

Files Change Summary
packages/synapse-interface/components/ui/AmountInput.tsx Introduced formatNumberWithCommas to format the input value for better readability.
packages/synapse-interface/pages/state-managed-bridge/index.tsx Updated toast messages to format debouncedFromValue using formatNumberWithCommas for improved clarity in user notifications.
packages/synapse-interface/utils/formatNumberWithCommas.ts Added formatNumberWithCommas function to format numeric strings with commas as thousand separators, enhancing the presentation of numerical values in the app.

Poem

In a garden bright and fair,
A rabbit hops without a care.
With numbers neat and commas bright,
The changes bring a pure delight!
Hooray for formats, clear and grand,
A joyful leap across the land! πŸ‡βœ¨

[!TIP] We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 months ago

Bundle Report

Changes will increase total bundle size by 264.58kB :arrow_up:

Bundle name Size Change
sdk-router-@synapsecns/sdk-router-cjs 527.05kB 409.81kB :arrow_up:
synapse-interface-client-array-push 7.41MB 228 bytes :arrow_up:
synapse-interface-server-cjs 1.33MB 145.45kB :arrow_down:
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 30.85118%. Comparing base (9ceacfe) to head (1f23a25). Report is 14 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3095 +/- ## =================================================== + Coverage 29.75114% 30.85118% +1.10004% =================================================== Files 408 388 -20 Lines 27646 26375 -1271 Branches 82 82 =================================================== - Hits 8225 8137 -88 + Misses 18659 17479 -1180 + Partials 762 759 -3 ``` | [Flag](https://app.codecov.io/gh/synapsecns/sanguine/pull/3095/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | Coverage Ξ” | | |---|---|---| | [packages](https://app.codecov.io/gh/synapsecns/sanguine/pull/3095/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `90.56974% <ΓΈ> (ΓΈ)` | | | [promexporter](https://app.codecov.io/gh/synapsecns/sanguine/pull/3095/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cloudflare-workers-and-pages[bot] commented 3 months ago

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1f23a25
Status: βœ…  Deploy successful!
Preview URL: https://642d4ffc.sanguine-fe.pages.dev
Branch Preview URL: https://fe-input-comma.sanguine-fe.pages.dev

View logs

cloudflare-workers-and-pages[bot] commented 3 months ago

Deploying sanguine with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1f23a25
Status: βœ…  Deploy successful!
Preview URL: https://bd2ee3b7.sanguine.pages.dev
Branch Preview URL: https://fe-input-comma.sanguine.pages.dev

View logs