synapsecns / sanguine

Synapse Monorepo
MIT License
43 stars 31 forks source link

fix(synapse-interface): Prevents extra vertical scroll when disconnected #3109

Closed abtestingalpha closed 2 months ago

abtestingalpha commented 2 months ago

Description When selecting the to chain/tokens, an extra scroll-bar would appear when the selector height when overflowing the screen. This happened when user was disconnected (because otherwise, the portfolio would provide the extra vertical buffer). PR removes the unnecessary scrollbar.

Summary by CodeRabbit

30e18efa043db89f683e00ec17b48223e1b3405b: synapse-interface preview link

coderabbitai[bot] commented 2 months ago

Walkthrough

The change involves modifying the overflow property of the main HTML element in the Home component of the index.tsx file. The adjustment transitions the overflow behavior from allowing vertical scrolling (overflow-y-auto) to disabling it (overflow-y-none), thus affecting how content is displayed when it exceeds the container's height.

Changes

Files Change Summary
packages/synapse-interface/... Changed overflow property from overflow-y-auto to overflow-y-none in the Home component.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HomeComponent
    User->>HomeComponent: View Content
    HomeComponent->>User: Display Content (no vertical scroll)

Poem

In a garden where rabbits play,
A change has come to brighten the day.
No more scrolling, just a view,
A cozy spot for me and you!
Hopping with joy, we celebrate,
A new way to enjoy our fate! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 316e4b4
Status: ✅  Deploy successful!
Preview URL: https://61ed6cf0.sanguine-fe.pages.dev
Branch Preview URL: https://fe-prevent-disconnected-scro.sanguine-fe.pages.dev

View logs

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.77326%. Comparing base (715269a) to head (316e4b4). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3109 +/- ## =================================================== + Coverage 32.74680% 33.77326% +1.02646% =================================================== Files 533 513 -20 Lines 33246 31975 -1271 Branches 82 82 =================================================== - Hits 10887 10799 -88 + Misses 21390 20210 -1180 + Partials 969 966 -3 ``` | [Flag](https://app.codecov.io/gh/synapsecns/sanguine/pull/3109/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | Coverage Δ | | |---|---|---| | [packages](https://app.codecov.io/gh/synapsecns/sanguine/pull/3109/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `90.56974% <ø> (ø)` | | | [promexporter](https://app.codecov.io/gh/synapsecns/sanguine/pull/3109/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying sanguine with  Cloudflare Pages  Cloudflare Pages

Latest commit: 316e4b4
Status: ✅  Deploy successful!
Preview URL: https://4e22f59d.sanguine.pages.dev
Branch Preview URL: https://fe-prevent-disconnected-scro.sanguine.pages.dev

View logs

codecov[bot] commented 2 months ago

Bundle Report

Changes will increase total bundle size by 22.77MB :arrow_up:

Bundle name Size Change
explorer-ui-client-array-push* 2.31MB 4 bytes :arrow_down:
docs-bridge-client-array-push* 7.9MB 7.9MB :arrow_up:
docs-bridge-server-cjs* 14.87MB 14.87MB :arrow_up:

ℹ️ *Bundle size includes cached data from a previous commit