search

synapsecns / sanguine

Synapse Monorepo
MIT License
43 stars 31 forks source link

FE Release 2024-09-16 #3129

Closed abtestingalpha closed 2 months ago

abtestingalpha commented 2 months ago

null 77859d5b26ac6f45c297f5191bfdf8419918e9f1: docs preview link 77859d5b26ac6f45c297f5191bfdf8419918e9f1: synapse-interface preview link

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 2 months ago

Walkthrough

This pull request introduces multiple changes across various files. A new linter for detecting magic numbers is added in the .golangci.yml configuration. The core/go.mod file includes a direct dependency on the google.golang.org/grpc package. Documentation enhancements for OTLP exporter configuration are made, along with new functionalities for handling multiple exporters in the metrics package. Additionally, API documentation is updated to include a versioning header, and a new interface for multicall functionality is defined in the contracts.

Changes

File Change Summary
.golangci.yml Added the mnd linter to detect magic numbers.
core/go.mod Added direct dependency on google.golang.org/grpc version v1.64.0, removing it from indirect dependencies.
core/metrics/README.md Enhanced documentation for OTLP exporter configuration, detailing environment variables for multiple exporters.
core/metrics/export_test.go, core/metrics/otlp_test.go Introduced HeadersToMap function for converting header strings to a map and added unit tests for it.
core/metrics/multiexporter.go, core/metrics/multiexporter_test.go Added MultiExporter interface and implementation for exporting spans to multiple OTLP exporters concurrently, along with unit tests for its functionality.
core/metrics/otlp.go Enhanced OTLP exporters to support multiple configurations based on environment variables, introducing new utility functions.
core/metrics/rookout.go Added import statement for the os package.
docs/bridge/docs/rfq/API/API.md Updated documentation to include the X-Api-Version HTTP response header.
packages/contracts-rfq/CHANGELOG.md Updated changelog for version 0.3.0 release, noting the introduction of a multicall target abstraction.
packages/contracts-rfq/contracts/interfaces/IMulticallTarget.sol, packages/contracts-rfq/contracts/utils/MulticallTarget.sol Defined an interface for multicall functionality and introduced MulticallTarget contract for executing batched calls while preserving msg.sender.
packages/contracts-rfq/package.json Updated version number to 0.3.0.
packages/contracts-rfq/test/MulticallTarget.t.sol Added comprehensive test suite for MulticallTarget functionality.
contrib/opbot/botmd/commands.go Enhanced traceCommand and rfqRefund functions with additional parameters and improved error handling.

Possibly related PRs

Suggested labels

size/s

🐰 In the meadow where bunnies hop,
New linters and features make our hearts stop!
With gRPC added, we dance and play,
Enhancing our code in a joyful way.
Documentation shines, clear as can be,
Hooray for the changes that set us all free! 🐇✨

Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 9aadad2fab8c0ec2999d93293812304e49214a42 and 0357100a67b1333fdd47944d965293ba9878c1f9.
Files ignored due to path filters (1) * `yarn.lock` is excluded by `!**/yarn.lock`, `!**/*.lock`
Files selected for processing (1) * packages/rest-api/package.json (2 hunks)
Files skipped from review as they are similar to previous changes (1) * packages/rest-api/package.json
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- `I pushed a fix in commit , please review it.` -- `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: -- `@coderabbitai generate unit testing code for this file.` -- `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- `@coderabbitai generate interesting stats about this repository and render them as a table.` -- `@coderabbitai read src/utils.ts and generate unit testing code.` -- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` -- `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Early access features: enabled We are currently testing the following features in early access: - **OpenAI `o1` for code reviews**: OpenAI's new o1 model is being tested for generating code suggestions in code reviews. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 67.53927% with 62 lines in your changes missing coverage. Please review.

Project coverage is 38.23421%. Comparing base (a240292) to head (377a7fa). Report is 28 commits behind head on fe-release.

Files with missing lines Patch % Lines
core/metrics/otlp.go 70.63492% 30 Missing and 7 partials :warning:
core/metrics/multiexporter.go 71.05263% 9 Missing and 2 partials :warning:
contrib/opbot/botmd/commands.go 0.00000% 10 Missing :warning:
contrib/opbot/botmd/botmd.go 0.00000% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## fe-release #3129 +/- ## ==================================================== + Coverage 33.38834% 38.23421% +4.84586% ==================================================== Files 343 423 +80 Lines 20603 24363 +3760 Branches 82 119 +37 ==================================================== + Hits 6879 9315 +2436 - Misses 13147 14309 +1162 - Partials 577 739 +162 ``` | [Flag](https://app.codecov.io/gh/synapsecns/sanguine/pull/3129/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | Coverage Δ | | |---|---|---| | [opbot](https://app.codecov.io/gh/synapsecns/sanguine/pull/3129/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `0.48960% <0.00000%> (-0.00302%)` | :arrow_down: | | [packages](https://app.codecov.io/gh/synapsecns/sanguine/pull/3129/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `90.96267% <ø> (ø)` | | | [promexporter](https://app.codecov.io/gh/synapsecns/sanguine/pull/3129/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `?` | | | [solidity](https://app.codecov.io/gh/synapsecns/sanguine/pull/3129/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `89.31298% <100.00000%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] commented 2 months ago

Bundle Report

Changes will increase total bundle size by 4.18kB (0.01%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes | Bundle name | Size | Change | | ----------- | ---- | ------ | | synapse-interface-client-array-push* | 7.5MB | 86 bytes :arrow_up: | | synapse-interface-server-cjs* | 1.62MB | 86 bytes :arrow_up: | | docs-bridge-client-array-push | 7.9MB | 1.2kB :arrow_up: | | docs-bridge-server-cjs | 14.88MB | 2.81kB :arrow_up: |

ℹ️ *Bundle size includes cached data from a previous commit

cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0357100
Status: ✅  Deploy successful!
Preview URL: https://31f2d22f.sanguine-fe.pages.dev
Branch Preview URL: https://master.sanguine-fe.pages.dev

View logs