synapsecns / sanguine

Synapse Monorepo
MIT License
43 stars 31 forks source link

Docs/lk exploration [SLT-170] #3141

Closed lawsonkight closed 2 months ago

lawsonkight commented 2 months ago

First pass at basic styling and content management for Synapse Docs.

Creates a new /docs/Overview page summarizing the sidebar content.

Proposal: top-level Routers folder for CCTP and RFQ content Proposal: rename Services to Essential Tools Proposal: add Observability to Essential Tools as Telemetry

Metadata

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

This pull request introduces comprehensive documentation for the CCTP Router, detailing its integration with Circle's Cross-Chain Transfer Protocol (CCTP) for minting and burning USDC. It includes a visual representation of the asset transfer flow, architecture interactions between Synapse and Circle contracts, and configuration instructions for the CCTP Relayer. Additionally, operational guidelines for running the relayer and monitoring transactions are included, along with an example YAML configuration.

Changes

Files Change Summary
docs/bridge/docs/04-Routers/CCTP/index.md Added detailed documentation for the CCTP Router, covering architecture, configuration, and operational instructions for the CCTP Relayer.
docs/bridge/package.json Updated dependencies and devDependencies for Docusaurus and React, including version upgrades and the addition of new dependencies.

Possibly related PRs

Suggested reviewers

🐇 In the garden of code, new wonders arise,
With bridges that connect, beneath endless skies.
Colors now sing in HSL's light,
As we hop through the changes, all feels just right.
So gather, dear friends, let’s leap and explore,
With the Synapse DAO, there’s always more! 🌼


📜 Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
📥 Commits Files that changed from the base of the PR and between bc0bf4c2a0b37e0d09d57658fca2fc7d9235310f and b3b708293888adb8231b969d743149175d2e6234.
⛔ Files ignored due to path filters (1) * `yarn.lock` is excluded by `!**/yarn.lock`, `!**/*.lock`
📒 Files selected for processing (1) * docs/bridge/package.json (1 hunks)
🔇 Additional comments (4)
docs/bridge/package.json (4)
`39-40`: **React and react-dom updates are appropriate.** The update of React and react-dom from ^18.0.0 to ^18.2.0 is a good practice. This minor version update likely includes bug fixes and performance improvements while maintaining compatibility within the React 18 ecosystem. --- `23-33`: **Docusaurus packages update looks good.** The update of Docusaurus core and related packages from 3.1.1 to 3.5.2 is a positive change. This minor version update likely includes new features, improvements, and bug fixes. To ensure a smooth transition, please run the following script to check for any breaking changes or notable new features: ```shell #!/bin/bash # Description: Check Docusaurus changelog for breaking changes and new features # Fetch the changelog changelog_url="https://github.com/facebook/docusaurus/blob/main/CHANGELOG.md" changelog=$(curl -s $changelog_url) # Extract changes between 3.1.1 and 3.5.2 echo "Changes between 3.1.1 and 3.5.2:" echo "$changelog" | sed -n '/## 3\.5\.2/,/## 3\.1\.1/p' | grep -E '(Breaking|Features?|Improvements?)' # Check if there are any breaking changes if echo "$changelog" | sed -n '/## 3\.5\.2/,/## 3\.1\.1/p' | grep -q 'Breaking'; then echo "Warning: Breaking changes detected. Please review carefully." fi ``` --- `36-37`: **OpenAPI documentation packages update is good, but verify compatibility.** The update of docusaurus-plugin-openapi-docs and docusaurus-theme-openapi-docs from 3.0.0-beta.10 to ^4.0.1 is a significant change. Moving to a stable version is beneficial, but as this is a major version update, it may include breaking changes. Please run the following script to check for any breaking changes or migration steps: ```shell #!/bin/bash # Description: Check OpenAPI docs packages for breaking changes # Fetch the changelog for docusaurus-plugin-openapi-docs plugin_changelog_url="https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/blob/main/CHANGELOG.md" plugin_changelog=$(curl -s $plugin_changelog_url) echo "Changes for docusaurus-plugin-openapi-docs:" echo "$plugin_changelog" | sed -n '/## \[4\.0\.1\]/,/## \[3\.0\.0-beta\.10\]/p' | grep -E '(Breaking|Features?|Improvements?)' # Fetch the changelog for docusaurus-theme-openapi-docs theme_changelog_url="https://github.com/PaloAltoNetworks/docusaurus-openapi-docs/blob/main/CHANGELOG.md" theme_changelog=$(curl -s $theme_changelog_url) echo "Changes for docusaurus-theme-openapi-docs:" echo "$theme_changelog" | sed -n '/## \[4\.0\.1\]/,/## \[3\.0\.0-beta\.10\]/p' | grep -E '(Breaking|Features?|Improvements?)' # Check if there are any breaking changes if echo "$plugin_changelog$theme_changelog" | sed -n '/## \[4\.0\.1\]/,/## \[3\.0\.0-beta\.10\]/p' | grep -q 'Breaking'; then echo "Warning: Breaking changes detected. Please review carefully and follow any migration steps." fi ``` --- `25-25`: **New dependencies look good, but clarification needed on synapse-constants.** The addition of Docusaurus-related dependencies (@docusaurus/module-type-aliases, @docusaurus/tsconfig, and @docusaurus/types) is likely to improve TypeScript support, which is beneficial for maintainability. The addition of synapse-constants (version 1.3.22) is noted, but its purpose in the documentation project is not immediately clear. Could you please provide more information about the synapse-constants package and its role in the documentation? Run the following script to check its contents: Also applies to: 29-30, 41-41
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: b3b7082
Status: ✅  Deploy successful!
Preview URL: https://bae1e627.sanguine-fe.pages.dev
Branch Preview URL: https://docs-lk-exploration.sanguine-fe.pages.dev

View logs

codecov[bot] commented 2 months ago

Bundle Report

Changes will increase total bundle size by 7.05MB (19.78%) :arrow_up::warning:, exceeding the configured threshold of 5%.

Bundle name Size Change
sdk-router-@synapsecns/sdk-router-cjs* 526.74kB 409.5kB (349.29%) :arrow_up::warning:
explorer-ui-server-cjs* 866.14kB 76 bytes (0.01%) :arrow_up:
explorer-ui-client-array-push* 2.31MB 152 bytes (0.01%) :arrow_up:
synapse-interface-client-array-push* 7.28MB 521 bytes (0.01%) :arrow_up:
synapse-interface-server-cjs* 1.64MB 147.69kB (9.88%) :arrow_up::warning:
widget-cjs-esm* 271.27kB 2.03kB (-0.74%) :arrow_down:
docs-bridge-client-array-push 10.57MB 2.67MB (33.73%) :arrow_up::warning:
docs-bridge-server-cjs 18.35MB 3.48MB (23.39%) :arrow_up::warning:
synapse-constants-esm-cjs* 174.63kB 174.63kB (100%) :arrow_up::warning:
synapse-constants-cjs-esm* 174.18kB 174.18kB (100%) :arrow_up::warning:

ℹ️ *Bundle size includes cached data from a previous commit

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.56974%. Comparing base (8f1899d) to head (9e9b993).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3141 +/- ## ============================================= Coverage 90.56974% 90.56974% ============================================= Files 54 54 Lines 1018 1018 Branches 82 82 ============================================= Hits 922 922 Misses 93 93 Partials 3 3 ``` | [Flag](https://app.codecov.io/gh/synapsecns/sanguine/pull/3141/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | Coverage Δ | | |---|---|---| | [packages](https://app.codecov.io/gh/synapsecns/sanguine/pull/3141/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `90.56974% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Defi-Moses commented 2 months ago

Some specific feedback. Happy to elaborate on any specific part.

Home page:

API:

Synapse Router:

CCTP:

Contracts: Synapse router:

Liquidity Pools

CCTP and RFQ contracts

Going to check some of these boxes myself but I think these are in a great state