ci: Solidity gas diff [SLT-259]

ChiTimesChi commented 2 months ago

Description

Replaces unused Solidity snapshot workflow with a Solidity Gas Diff, that is supposed to post a PR comment with the gas diffs realted to the contract changes in the PR.
Made package skipping more generic in solidity workflows

Summary by CodeRabbit

New Features
- Enhanced gas efficiency for the FastBridgeV2 contract by updating function parameters to accept calldata.
- Introduced a structured workflow for testing and generating gas reports in the CI/CD process, including gas report comparisons in pull requests.
Bug Fixes
- Improved clarity and organization of testing jobs within the CI/CD workflow.

coderabbitai[bot] commented 2 months ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The pull request introduces changes to the GitHub Actions workflow for Solidity and updates the FastBridgeV2 contract. The workflow modifications include restructuring testing jobs and enhancing gas report generation. In the contract, several public function parameters are updated from bytes memory to bytes calldata, improving gas efficiency while maintaining the existing functionality.

Changes

File	Change Summary
`.github/workflows/solidity.yml`	Restructured testing jobs, split Foundry tests into distinct steps, updated job names, added gas report comparison and comments.
`packages/contracts-rfq/contracts/FastBridgeV2.sol`	Updated public function parameter types from `bytes memory` to `bytes calldata` for efficiency.

Possibly related PRs

#3181: This PR modifies the .github/workflows/solidity.yml file, which is directly related to the changes made in the main PR regarding the restructuring of the Foundry testing and coverage jobs.
#3138: This PR involves changes to the FastBridgeV2 contract, specifically the relay and claim functions, which are also mentioned in the main PR's summary of changes to the FastBridgeV2 contract.

Suggested labels

size/m

Suggested reviewers

ChiTimesChi
trajan0x
aureliusbtc

Poem

In the meadow where bunnies play,
Code has danced and found its way.
With calldata now, we hop with glee,
Efficiency blooms like a bright spring tree.
Gas reports flutter, a joyous sight,
In the world of contracts, all feels right! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

:heart: Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

:placard: Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying sanguine-fe with Cloudflare Pages

Latest commit:	`35d001e`
Status:	⚡️ Build in progress...

View logs

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.44864%. Comparing base (9418b40) to head (35d001e). Report is 13 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #3181 +/- ## =================================================== - Coverage 41.54443% 38.44864% -3.09580% =================================================== Files 460 424 -36 Lines 25770 24456 -1314 Branches 357 146 -211 =================================================== - Hits 10706 9403 -1303 + Misses 14326 14315 -11 Partials 738 738 ``` | [Flag](https://app.codecov.io/gh/synapsecns/sanguine/pull/3181/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | Coverage Δ | | |---|---|---| | [packages](https://app.codecov.io/gh/synapsecns/sanguine/pull/3181/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `90.96267% <ø> (ø)` | | | [solidity](https://app.codecov.io/gh/synapsecns/sanguine/pull/3181/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `93.51852% <ø> (-4.84750%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] commented 2 months ago

Bundle Report

Changes will decrease total bundle size by 150.12kB (-0.42%) :arrow_down:. This is within the configured threshold :white_check_mark:

Detailed changes

| Bundle name | Size | Change | | ----------- | ---- | ------ | | synapse-interface-client-array-push* | 7.26MB | 3.09kB (0.04%) :arrow_up: | | synapse-interface-server-cjs | 1.47MB | 142.55kB (-8.82%) :arrow_down: | | widget-esm-cjs | 273.3kB | 10.65kB (-3.75%) :arrow_down: |

ℹ️ *Bundle size includes cached data from a previous commit

synapsecns / sanguine