search

synapsecns / sanguine

Synapse Monorepo
MIT License
43 stars 31 forks source link

[SLT-234] feat(rfq): dynamic block conf wait + receipt x event quote check w/ RPC consensus #3190

Open golangisfun123 opened 2 months ago

golangisfun123 commented 2 months ago

Description A clear and concise description of the features you're adding in this pull request.

Additional context Add any other context about the problem you're solving.

Metadata

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The pull request introduces significant modifications across various files related to the relayer configuration and transaction handling. Key changes include the addition of a VolumeLimit field in specific configurations, enhancements to the rate limiter's logic for transaction validation, and updates to test cases to align with new transaction structures. Additionally, new methods are added to retrieve chain-specific confirmation limits, and the overall configuration structure is reorganized to improve clarity and functionality.

Changes

File Path Change Summary
services/rfq/e2e/setup_test.go Added VolumeLimit field with value 10_000 in two configuration instances; removed global VolumeLimit declaration.
services/rfq/relayer/limiter/limiter.go Introduced checkReceipt method; updated IsAllowed logic to include volume limit checks; renamed and modified withinSizeLimit to isUnderVolumeLimit.
services/rfq/relayer/limiter/limiter_test.go Updated test cases to reflect new transaction structures; added helper functions for transaction data simulation.
services/rfq/relayer/limiter/suite_test.go Updated chain configuration for chain ID 10; added new configuration for chain ID 81457 with specific parameters.
services/rfq/relayer/relconfig/config.go Removed VolumeLimit from Config; added VolumeLimit and RPCConfirmations to ChainConfig.
services/rfq/relayer/relconfig/getters.go Added GetRPCConfirmations method; modified GetVolumeLimit to use chain-specific limits.
services/rfq/util/util.go Updated QuoteRequestToAttributes function to accept a pointer to QuoteRequest instead of a value.

Possibly related PRs

Suggested labels

M-docs

Suggested reviewers

Poem

In the meadow where bunnies play,
New limits and checks have come our way!
With volume set and confirmations right,
Our transactions will hop with delight!
So let's cheer for the code that's bright,
A relayer's dream, taking flight! πŸ‡βœ¨

πŸ“œ Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
πŸ“₯ Commits Files that changed from the base of the PR and between 353b63c6e36249d829caa9f0c8608172468d28f6 and 5bc30047825375611eafc319b050161d6a4b7f64.
πŸ“’ Files selected for processing (1) * services/rfq/relayer/limiter/limiter.go (6 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * services/rfq/relayer/limiter/limiter.go
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❀️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
πŸͺ§ Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 55.66038% with 47 lines in your changes missing coverage. Please review.

Project coverage is 33.07430%. Comparing base (f0b13bc) to head (5bc3004). Report is 264 commits behind head on master.

Files with missing lines Patch % Lines
services/rfq/relayer/limiter/limiter.go 66.29213% 24 Missing and 6 partials :warning:
services/rfq/relayer/service/statushandler.go 0.00000% 9 Missing :warning:
services/rfq/relayer/relconfig/getters.go 0.00000% 7 Missing :warning:
services/rfq/util/util.go 0.00000% 1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (f0b13bc) and HEAD (5bc3004). Click for more details.

HEAD has 2 uploads less than BASE | Flag | BASE (f0b13bc) | HEAD (5bc3004) | |------|------|------| |solidity|2|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3190 +/- ## =================================================== - Coverage 40.97804% 33.07430% -7.90374% =================================================== Files 459 535 +76 Lines 25643 33715 +8072 Branches 343 82 -261 =================================================== + Hits 10508 11151 +643 - Misses 14383 21575 +7192 - Partials 752 989 +237 ``` | [Flag](https://app.codecov.io/gh/synapsecns/sanguine/pull/3190/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | Coverage Ξ” | | |---|---|---| | [opbot](https://app.codecov.io/gh/synapsecns/sanguine/pull/3190/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `0.48870% <ΓΈ> (ΓΈ)` | | | [promexporter](https://app.codecov.io/gh/synapsecns/sanguine/pull/3190/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `6.81642% <ΓΈ> (?)` | | | [solidity](https://app.codecov.io/gh/synapsecns/sanguine/pull/3190/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: bfd1761
Status: βœ…  Deploy successful!
Preview URL: https://eafc0c77.sanguine-fe.pages.dev
Branch Preview URL: https://rpc-confirmations.sanguine-fe.pages.dev

View logs

github-actions[bot] commented 1 month ago

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 month ago

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 week ago

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.