coderabbitai[bot]
commented
1 month ago Walkthrough
The changes in this pull request involve modifications to the .github/workflows/solidity.yml file, focusing on the exclusion of the solidity-devops package from specific jobs. Comments were added for clarity, and the exclusion logic was restructured. Additionally, two new Solidity test contracts named GasBenchmarkTest were introduced in separate files, each containing a public function that is currently empty. These changes do not affect the core functionality of the workflow or the existing job definitions.
Changes
| File Path | Change Summary |
|---|---|
.github/workflows/solidity.yml |
Added comments and restructured exclusion logic for solidity-devops package in jobs like slither, gas-diff, and size-check. Retained if conditions for job execution based on package changes. |
packages/contracts-core/test/GasBenchmark.t.sol |
Introduced GasBenchmarkTest contract with an empty testGasBenchmark function; noted no gas benchmark is required for contracts-core. |
packages/solidity-devops/test/GasBenchmark.t.sol |
Introduced GasBenchmarkTest contract with an empty testGasBenchmark function; noted no gas benchmark is required for solidity-devops. |
Possibly related PRs
- #3181: This PR modifies the
.github/workflows/solidity.ymlfile to enhance the gas diff workflow, which includes adding exclusions for thesolidity-devopspackage, similar to the changes made in the main PR. - #3193: This PR also updates the
.github/workflows/solidity.ymlfile by adding parameters to the gas diff action, which relates to the exclusion logic for thesolidity-devopspackage. - #3204: This PR modifies the workflow for Solidity testing, including changes to how gas reports are generated, which aligns with the restructuring of exclusion logic in the main PR.
- #3217: This PR introduces gas benchmark tests for the views within the contracts, which may relate to the overall gas efficiency focus seen in the main PR's workflow changes.
Suggested labels
needs-go-generate-services/rfq
Suggested reviewers
- trajan0x
- bigboydiamonds
🐰 In the meadow, changes bloom,
With contracts new, there's plenty of room.
Exclusions clear, the workflow's bright,
Gas benchmarks stand, ready for flight.
Hop along, let progress ring,
In the code, we joyfully spring! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
cloudflare-workers-and-pages[bot]
codecov[bot]
Description A clear and concise description of the features you're adding in this pull request.
Additional context Add any other context about the problem you're solving.
Metadata
Summary by CodeRabbit
GasBenchmarkTestcontracts in bothcontracts-coreandsolidity-devopspackages for future gas benchmarking tests.solidity-devopspackage from specific jobs in the workflow configuration.