search

synapsecns / sanguine

Synapse Monorepo
MIT License
43 stars 31 forks source link

trace [SLT-330] #3264

Closed trajan0x closed 1 month ago

trajan0x commented 1 month ago

[goreleaser]

Description A clear and concise description of the features you're adding in this pull request.

Additional context Add any other context about the problem you're solving.

Metadata

Summary by CodeRabbit

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 30.68453%. Comparing base (648088c) to head (0b2dc8e). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...s/omnirpc/modules/receiptsbackup/receiptsbackup.go 0.00000% 8 Missing :warning:
ethergo/util/attributes.go 40.00000% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3264 +/- ## =================================================== + Coverage 24.97972% 30.68453% +5.70480% =================================================== Files 340 447 +107 Lines 22190 29787 +7597 Branches 82 82 =================================================== + Hits 5543 9140 +3597 - Misses 16081 19797 +3716 - Partials 566 850 +284 ``` | [Flag](https://app.codecov.io/gh/synapsecns/sanguine/pull/3264/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | Coverage Δ | | |---|---|---| | [cctp-relayer](https://app.codecov.io/gh/synapsecns/sanguine/pull/3264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `31.97848% <ø> (ø)` | | | [ethergo](https://app.codecov.io/gh/synapsecns/sanguine/pull/3264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `47.27896% <40.00000%> (?)` | | | [omnirpc](https://app.codecov.io/gh/synapsecns/sanguine/pull/3264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `32.66914% <0.00000%> (-0.12157%)` | :arrow_down: | | [opbot](https://app.codecov.io/gh/synapsecns/sanguine/pull/3264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `0.48870% <ø> (ø)` | | | [promexporter](https://app.codecov.io/gh/synapsecns/sanguine/pull/3264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `6.81642% <ø> (ø)` | | | [rfq](https://app.codecov.io/gh/synapsecns/sanguine/pull/3264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `24.61876% <ø> (+0.09874%)` | :arrow_up: | | [scribe](https://app.codecov.io/gh/synapsecns/sanguine/pull/3264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `18.24614% <ø> (ø)` | | | [tools](https://app.codecov.io/gh/synapsecns/sanguine/pull/3264/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `30.55118% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0b2dc8e
Status: ✅  Deploy successful!
Preview URL: https://4cda0d15.sanguine-fe.pages.dev
Branch Preview URL: https://fix-track-issue.sanguine-fe.pages.dev

View logs

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes in this pull request introduce a new constant txRawAttr in the attributes.go file to enhance transaction attribute handling. The TxToAttributes function is modified to include the raw binary representation of transactions. Additionally, the processRequest method in receiptsbackup.go is updated to include tracing functionality, logging events related to request and response bodies. A comment indicating future tracing requirements is added to the Request interface in client.go. The overall structure and functionality of the affected components remain unchanged.

Changes

File Path Change Summary
ethergo/util/attributes.go Added constant txRawAttr and modified TxToAttributes function to include marshaled transaction attributes.
ethergo/util/attributes_test.go Enhanced TestTxToAttributesDynamicTX to verify marshaled transaction data representation.
ethergo/util/export_test.go Added constant TxRawAttr for testing purposes.
services/omnirpc/http/client.go Added comment // TODO: this needs to support tracing. in Request interface.
services/omnirpc/modules/receiptsbackup/receiptsbackup.go Enhanced processRequest method with tracing functionality, including logging of request and response bodies.

Possibly related PRs

Suggested labels

size/m, needs-go-generate-contrib/promexporter

Suggested reviewers

🐰 In the code where the requests flow,
A little tracing now will grow!
With logs to see both request and reply,
Our observability will surely fly!
So hop along, let’s make it bright,
With every change, we’ll trace the light! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.