coderabbitai[bot]
commented
1 month ago Walkthrough
The changes in this pull request focus on the FastBridgeV2 contract, enhancing the handling of bridge transactions, dispute resolution, refunds, and claims. Key modifications include updates to the dispute, refund, claim, bridge, and relay functions, with new logic for transferring tokens based on their type (ETH or ERC20) and improved error handling. Additionally, method signatures have been updated to reflect new parameters. The associated test contract has also been modified to rename a parameter for clarity.
Changes
| File | Change Summary |
|---|---|
| packages/contracts-rfq/contracts/FastBridgeV2.sol | - Updated dispute function to capture disputedRelayer and modify emitted events. - Altered refund logic to use conditional checks for ETH/ERC20 transfers, updating emitted events accordingly. - Modified claim function for conditional token transfers and updated events. - Refined bridge function to handle originFeeAmount correctly and adjusted event emissions. - Clarified relay function logic for ETH/ERC20 transfers. - Enhanced error handling throughout the contract. - Method signatures updated for bridge, relay, claim, and prove functions. |
| packages/contracts-rfq/test/FastBridgeV2.Src.t.sol | - Renamed guard parameter to relayer in expectBridgeProofDisputed function and updated all instances accordingly. - Removed comments about previous parameter mislabeling for clarity. |
Sequence Diagram(s)
sequenceDiagram
participant User
participant FastBridgeV2
participant TokenContract
User->>FastBridgeV2: initiateBridge(params)
FastBridgeV2->>TokenContract: transferTokens()
TokenContract-->>FastBridgeV2: confirmTransfer()
FastBridgeV2->>User: emitBridgeEvent()
User->>FastBridgeV2: disputeTransaction()
FastBridgeV2->>FastBridgeV2: captureDisputedRelayer()
FastBridgeV2->>User: emitDisputeEvent()
User->>FastBridgeV2: requestRefund()
FastBridgeV2->>TokenContract: conditionalTransfer()
TokenContract-->>FastBridgeV2: confirmRefund()
FastBridgeV2->>User: emitRefundEvent()
User->>FastBridgeV2: claimCollateral()
FastBridgeV2->>TokenContract: conditionalTransfer()
TokenContract-->>FastBridgeV2: confirmClaim()
FastBridgeV2->>User: emitClaimEvent()Possibly related PRs
- #3138: This PR introduces overloads for the
relay,prove, andclaimfunctions in theFastBridgeV2contract, which are directly related to the changes made in the main PR regarding therelayandclaimfunctionalities. - #3169: This PR modifies the
provefunction in theFastBridgeV2contract, aligning with the changes in the main PR that also update theprovefunction's signature and logic. - #3170: This PR enhances the
relayfunction by storing the relayer address, which is relevant to the updates made in the main PR regarding therelayfunctionality. - #3172: This PR rearranges refund validation checks in the
FastBridgeV2contract, which is directly related to the changes in the main PR that also focus on therefundfunction. - #3173: This PR consolidates the
bridgeStatusesandbridgeProofsmappings into a single structure, which relates to the overall restructuring of theFastBridgeV2contract in the main PR. - #3204: This PR introduces gas estimation tests for the RFQ contracts, which may indirectly relate to the changes in the main PR as they both deal with the
FastBridgeV2contract. - #3246: This PR adds functionality for arbitrary calls with value in the
FastBridgeV2contract, which is relevant to the enhancements made in the main PR regarding the handling of bridge transactions. - #3251: This PR adds tests for revert conditions in the
bridgeandrelayfunctions, which are directly related to the changes made in the main PR that focus on error handling and transaction management. - #3273: This PR introduces gas benchmark tests for arbitrary calls, which aligns with the performance and functionality improvements made in the main PR regarding the
FastBridgeV2contract.
Suggested labels
size/m, M-deps, M-synapse-interface
Suggested reviewers
- trajan0x
- ChiTimesChi
Poem
In the realm of bridges wide,
Tokens dance, with joy and pride.
Disputes resolved, and refunds flow,
With every claim, our spirits grow.
A relayer's role, now clear and bright,
In FastBridgeV2, all feels just right! πβ¨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
cloudflare-workers-and-pages[bot]
codecov[bot]
github-actions[bot]
gas optimized claim/refund transfers -- no longer using universalTransfer
dispute (& respective tests) switched to emitting relayer (as was always indicated by the output param label), not guard address.
storage-read optimizations to come in a follow-up PR
Summary by CodeRabbit
New Features
Bug Fixes
Documentation