coderabbitai[bot]
commented
2 weeks ago Walkthrough
The changes in this pull request focus on enhancing the quoter.go file, specifically the generateActiveRFQ and generateQuotes methods within the Manager struct. A new field, OriginAmountExact, is added to the QuoteInput struct to accommodate exact deposit amounts during quote generation. The logic for handling these amounts is integrated into the quote generation process, including error handling improvements and adjustments to the getOriginAmount method to ensure quotes meet the specified deposit requirements. Additionally, several related files and test cases have been updated to reflect these changes.
Changes
| File Path | Change Summary |
|---|---|
| services/rfq/relayer/quoter/quoter.go | - Added OriginAmountExact *big.Int field to QuoteInput struct.- Enhanced generateActiveRFQ method to parse and include deposit amounts in quotes.- Updated getOriginAmount method to check and adjust quote amounts based on deposit requirements.- Modified generateQuotes method to initialize OriginAmountExact to nil in QuoteInput instances.- Improved error handling during deposit parsing and quote generation. |
| services/rfq/relayer/quoter/quoter_test.go | - Added TestGetOriginAmountActiveQuotes method to test GetOriginAmount functionality with various quote parameter scenarios. |
| services/rfq/api/db/api_db.go | - Renamed OriginAmount field to OriginAmountExact in ActiveQuoteRequest struct.- Updated FromUserRequest function to reflect the new field name. |
| services/rfq/api/model/request.go | - Renamed OriginAmount field to OriginAmountExact in QuoteData struct. |
| services/rfq/api/model/response.go | - Renamed OriginAmount field to OriginAmountExact in GetOpenQuoteRequestsResponse struct. |
| services/rfq/api/rest/handler.go | - Updated dbActiveQuoteRequestToModel function to replace OriginAmount with OriginAmountExact. |
| services/rfq/api/rest/rfq.go | - Updated methods to use OriginAmountExact instead of OriginAmount, affecting both active and passive RFQ handling. |
| services/rfq/api/rest/rfq_test.go | - Updated test cases to replace OriginAmount with OriginAmountExact in PutRFQRequest data model. |
| services/rfq/api/rest/server_test.go | - Updated TestGetOpenQuoteRequests function to replace OriginAmount with OriginAmountExact in test requests. |
| services/rfq/api/docs/docs.go | - Updated API documentation to reflect the renaming of origin_amount to origin_amount_exact in relevant schemas. |
Possibly related PRs
- #3128: The changes in the main PR involve significant modifications to the
quoter.gofile, particularly in theManagerstruct and its methods, which are also addressed in the active quoting API introduced in this PR. - #3198: This PR enhances the functionality of the relayer by enabling it to support active quoting, which is directly related to the changes made in the main PR regarding quote handling and processing.
- #3288: The main PR's focus on profitability checks aligns with the changes made in this PR, which also addresses profitability assessments in the context of RFQ processing.
- #3323: The introduction of an API gateway for the RFQ indexer and RFQ API relates to the overall enhancements in the RFQ system, including the changes made in the main PR regarding quote handling and processing.
Suggested labels
size/l
Suggested reviewers
- dwasse
- trajan0x
- aureliusbtc
- bigboydiamonds
π In the meadow, where quotes do play,
A deposit's dance brightens the day.
With amounts now checked, and errors refined,
Our quoting's robust, perfectly aligned.
Hop, hop, hooray, for changes so bright,
In the world of RFQs, all feels just right! π
[!WARNING] There were issues while running some tools. Please review the errors and either fix the toolβs configuration or disable the tool if itβs a critical failure.
π§ golangci-lint
level=warning msg="[config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`." level=warning msg="[config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`." level=warning msg="[config_reader] The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`." level=warning msg="[lintersdb] The linter \"maligned\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"exhaustivestruct\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"ifshort\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"interfacer\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"nosnakecase\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The name \"goerr113\" is deprecated. The linter has been renamed to: err113." level=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar." level=warning msg="The linter 'execinquery' is deprecated (since v1.58.0) due to: The repository of the linter has been archived by the owner. "
π Recent review details
**Configuration used: .coderabbit.yaml** **Review profile: CHILL**π₯ Commits
Reviewing files that changed from the base of the PR and between 02e893beaf0f6974b08cd34889a0ea8a5c3dd6e2 and 1a323656875bd1d1f504ee941803266154c4016b.π Files selected for processing (2)
* `services/rfq/api/docs/docs.go` (2 hunks) * `services/rfq/api/model/request.go` (1 hunks)π§ Files skipped from review as they are similar to previous changes (1)
* services/rfq/api/model/request.goπ Additional comments (2)
services/rfq/api/docs/docs.go (2)
`350-350`: **LGTM: Property rename in GetOpenQuoteRequestsResponse** The rename from `origin_amount` to `origin_amount_exact` aligns with the PR objective of incorporating exact deposit amounts into the ActiveQuoting system. Let's verify the consistency of this rename across the codebase: --- `514-514`: **LGTM: Property rename in QuoteData** The rename from `origin_amount` to `origin_amount_exact` in the QuoteData model maintains consistency with the ActiveQuoting enhancement. Let's verify the request/response handling for this property:β Verification successful
**Property rename verified successfully.**π Scripts executed
The following scripts were executed for the analysis: Script: ```shell #!/bin/bash # Description: Check for proper request/response handling of the renamed property # Search for QuoteData struct definition and usage ast-grep --pattern 'type QuoteData struct { $$$ origin_amount_exact $$$ $$$ }' # Check for any JSON marshaling/unmarshaling of this property rg -g '!*.go.swp' '(json\.Marshal|json\.Unmarshal).*QuoteData' ``` Length of output: 151 --- Script: ```shell #!/bin/bash # Description: Search for all usages of 'origin_amount_exact' in the codebase rg 'origin_amount_exact' ``` Length of output: 576 --- Script: ```shell #!/bin/bash # Description: Verify that 'origin_amount' is no longer used in the QuoteData struct ast-grep --pattern 'type QuoteData struct { $$$ origin_amount $$$ $$$ }' ``` Length of output: 80Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
cloudflare-workers-and-pages[bot]
codecov[bot]
ActiveQuoting needs to consider the deposit amount when preparing an Active RFQ response and utilize it to calculate a corresponding dest amount.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
origin_amounttoorigin_amount_exactfor clarity and precision in data representation.