synapsestudios / terraform-aws-ecs-service

MIT License
1 stars 0 forks source link

Make assign public IP default better #38

Open dragonfleas opened 5 months ago

dragonfleas commented 5 months ago

Description

The assign_public_ip is set to false as the default for the ECS service resource. Since we primarily use Fargate containers which by default utilize (and require) the awsvpc network type also requiring the auto assign public IP to be true, we should change the default to be true, or make it a required variable. I'd opt for the former considering backwards compatibility.

Reference

https://github.com/synapsestudios/terraform-aws-ecs-service/blob/cc9e62e6d58624cf88e680fd87851981dbb9f1e6/variables.tf#L138-L142