refactor: abi err msg parse

wenyuanhust commented 9 months ago

Closes: #274

Description

At present, if the call of solidity contract failed, things like this printed

Contract call reverted with data: 0x08c379a00000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000001c74657374206661696c656420746f2063726561746520636c69656e7400000000

After this pr, following will be printed

test failed to create client

which makes error message more human friendly. I haven't found a rust crate to do it, so I parse 2 kinds of errors mannually.

PR author checklist:

[ ] Added changelog entry, using unclog.
[ ] Added tests: integration (for Forcerelay) or unit/mock tests (for modules).
[ ] Linked to GitHub issue.
[ ] Updated code comments and documentation (e.g., docs/).
[ ] Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

blckngm commented 9 months ago

See #390 where I tried to address the aforementioned problems.

Flouse commented 9 months ago

replaced by https://github.com/synapseweb3/forcerelay/pull/390

synapseweb3 / forcerelay

refactor: abi err msg parse #388

Description

PR author checklist:

Reviewer checklist: