In the filter menu dialog, the Filter button is rendered to execute the filtering action. The text on this button can be localized using the FilterButton locale keyword. When applying localization to the FilterButton (using the locale keyword), the same localized text is displayed on both the Filter Icon's tooltip (title) and the Filter dialog header in the Adaptive UI. We need to provide an option to customize the Filter Icon's tooltip and the Filter dialog header text with separate locale keywords.
Root cause
In the Adaptive UI grid, both the Filter Icon's title and the Filter Dialog header text are derived from the same locale keyword (FilterButton), which is causing the issue.
Reason for not identifying earlier
Find how it was missed in our earlier testing and development by analyzing the below checklist. This will help prevent similar mistakes in the future.
[ ] Guidelines/documents are not followed
Common guidelines / Core team guideline
Specification document
Requirement document
[x] Guidelines/documents are not given
Common guidelines / Core team guideline
Specification document
Requirement document
Reason:
Guidelines/documents are not given - Requirement document
We have provided separate locale keywords for the filter icon, sort icon title, and filter dialog header text. Now, each element's text is localized using its specific keyword.
Bug description
In the filter menu dialog, the Filter button is rendered to execute the filtering action. The text on this button can be localized using the FilterButton locale keyword. When applying localization to the FilterButton (using the locale keyword), the same localized text is displayed on both the Filter Icon's tooltip (title) and the Filter dialog header in the Adaptive UI. We need to provide an option to customize the Filter Icon's tooltip and the Filter dialog header text with separate locale keywords.
Root cause
In the Adaptive UI grid, both the Filter Icon's title and the Filter Dialog header text are derived from the same locale keyword (FilterButton), which is causing the issue.
Reason for not identifying earlier
Find how it was missed in our earlier testing and development by analyzing the below checklist. This will help prevent similar mistakes in the future.
[ ] Guidelines/documents are not followed
Common guidelines / Core team guideline
Specification document
Requirement document
[x] Guidelines/documents are not given
Common guidelines / Core team guideline
Specification document
Requirement document
Reason:
Guidelines/documents are not given - Requirement document
Action taken:
Added the manual testing sample to ensure this issue in future. You can find the testbed sample in the below location. https://github.com/essential-studio/ej2-grid-playwright-test/pull/602
Related areas:
Adaptive Grid, Sort, Filter, Localization
Is it a breaking issue?
No
Solution description
We have provided separate locale keywords for the filter icon, sort icon title, and filter dialog header text. Now, each element's text is localized using its specific keyword.
Output screenshots
Before
After
Areas affected and ensured
Responsive-dialog-renderer.ts file getHeaderTitle method Toolbar.ts file render method Grid.ts file initProperties method
Ensured the following cases:
Additional checklist
This may vary for different teams or products. Check with your scrum masters.
Did you run the automation against your fix? - Yes
Is there any API name change? - No
Is there any existing behavior change of other features due to this code change? - No
Does your new code introduce new warnings or binding errors? - No
Does your code pass all FxCop and StyleCop rules? a- No
Did you record this case in the unit test or UI test? - Yes