ghost
commented
5 years ago Hello,
I've been studying the case and I've found the solution about your code.
The file affected in last versions of the ej2-react-dropdowns package, at least in the last version 16.4.55, is the one in the path \node_modules\@syncfusion\ej2-dropdowns\src\multi-select\multi-select.js, specifically on line 1367. So there is a mistake in the declaration of the function refreshPlaceHolder in the conditional statement if ((this.value && this.value.length) || !isNullOrUndefined(this.text)). Check the function:
MultiSelect.prototype.refreshPlaceHolder = function() {
if (this.placeholder && this.floatLabelType === 'Never') {
if ((this.value && this.value.length) || !isNullOrUndefined(this.text)) {
this.inputElement.placeholder = '';
} else {
this.inputElement.placeholder = this.placeholder;
}
} else {
this.setFloatLabelType();
}
this.expandTextbox();
};On previous versions that had this feature well implemented, for example in version 16.4.52 from 5th February 2019, the conditional statement looked like if (this.value && this.value.length), so as you can see there was not the new extra condition !isNullOrUndefined(this.text).
So in the correct old version 16.4.52, whenever the value is an empty string (no options selected from the MultiSelectComponent) it will place the placeholder properly, while in the incorrect new version 16.4.55, whenever the value is an empty string it will reset the placeholder with an empty string, and this should not happen.
As now is implemented, when all the options from the component are unselected, the value is set to an empty string and matches the condition !isNullOrUndefined(this.text), so it will reset the placeholder to an empty string. As it was before in previous correct versions, whether the value was null, undefined, or an empty string it placed the placeholder properly, and when the value was a non-empty string it reseted it properly. But as it is now is just doing it the incorrect way.
So please, can you consider in publishing a new last official version of the package ej2-react-dropdowns where you remove the second condition !isNullOrUndefined(this.text) from the conditional statement that I mentioned? This will fix the issue. I think this is the only thing you must modify, but if you consider there are other things affected to this just modify them too, please.
Regards, Néstor Llamas Llopis
Gopigovin
PrinceOliver
Hello,
I have a problem with the
MultiSelectComponentin React, specifically with theplaceholderproperty.Consider this link.
As you can see in the demo, when you unselect all the previous selected options, the
placeholder"Select countries" appears again just as the beginning, but in the StackBlitz example associated theplaceholderdissapears after selecting and unselecting all the options, so theplaceholdercan only be obtained again if the page is refreshed. It seems to be related to the version of the packageej2-react-dropdowns. The demo is just using an old version of the package and the StackBlitz example is using the last version, as I can see inpackage.jsonfile. So I think it is incorrect as it is implemented now, this feature should be implemented as it was before, it's not logical that theplaceholderdissapears. So will you correct it? Did you do that in purpose?Regards, Néstor Llamas Llopis