syncfusion / flutter-widgets

Syncfusion Flutter widgets libraries include high quality UI widgets and file-format packages to help you create rich, high-quality applications for iOS, Android, and web from a single code base.
1.55k stars 752 forks source link

Performance issues on Flutter 3.22.2 #1984

Closed berslen closed 3 weeks ago

berslen commented 1 month ago

Bug description

I am having major performance issues for the datagrid in WEB platform. I compared the performance of the same code with Flutter version 3.19.6. My table has 2 fixed columns and the rest of the columns are normal columns. I can't share the whole code. Please do compare the performnace in given flutter versions. I compared the same code with Windows platform and web is 6x times slower in Flutter 3.22.2 but in 3.19.6 the difference is only 2x. (0.4s vs 1.2s)

Steps to reproduce

  1. Add fixed columns
  2. see performance in flutter version 3.22.2
  3. change flutter version to 3.19.6
  4. see the performance in flutter version 3.19.6

Code sample

Code sample ```dart [Add your code here] ```

Screenshots or Video

Screenshots / Video demonstration [Upload media here]

Stack Traces

Stack Traces ```dart [Add the Stack Traces here] ```

On which target platforms have you observed this bug?

Web

Flutter Doctor output

Doctor output ```console [Add your output here] ```
abineshPalanisamy commented 1 month ago

Hi @berslen ,

Based on the details provided, we have reviewed the performance of the DataGrid on both web and Windows platforms. After a thorough analysis, we did not identify any performance issues. To assist you further and better understand the problem, we kindly request that you provide additional details or steps on how you measured performance and conducted comparisons. Additionally, please replicate the performance issue in a simple sample and, if possible, provide a video recording demonstrating the issue for better clarity. This will greatly assist us in investigating the issue further and providing an appropriate solution as quickly as possible.

Regards, Abinesh P

berslen commented 1 month ago

here is the example, keep in mind you need to change index.html of the web folder according to the flutter version, just delete the web folder and add web platform when you changed the flutter version. you can definetly see the 1-2 seconds delay loading the table when you select new column datagrid.zip

abineshPalanisamy commented 1 month ago

Hi @berslen ,

Based on the provided sample and details, we tested the time taken to add a new column to the DataGrid by selecting the checkbox. After thorough analysis, we did not observe any major differences between versions 3.22.3 and 3.19.6 on both web and Windows platforms. When we switched to version 3.19.6, we removed the web folder as you mentioned, created a new web folder, and then conducted the tests. Additionally, we have included the performance metrics image.

If you are still encountering the same issue, we kindly request that you provide additional details or steps on how you measured performance and conducted comparisons. This will greatly assist us in investigating the issue further and providing an appropriate solution as quickly as possible.

Regards, Abinesh P

berslen commented 1 month ago

if you can tell me how did you measure these times, i'll make the same on my side and share it with you

abineshPalanisamy commented 1 month ago

Hi @berslen ,

We tested the time taken to add a new column to the DataGrid by selecting the checkbox. We started a stopwatch within the setState while adding the column at runtime and stopped it after the updateDataSource operation. The elapsed time was measured using stopwatch.elapsedMilliseconds. We have attached the sample we used to test the performance.

If there are any misunderstandings or if your needs differ, we kindly request that you provide additional details or steps on how you measured performance, conducted comparisons, or modified the attached sample. This will greatly assist us in investigating the issue further and providing an appropriate solution as quickly as possible.

Regards, Abinesh P

ashok-kuvaraja commented 3 weeks ago

Hi @berslen,

We suspect that the reported issue has been resolved at your end. We are closing this issue now. If you need any further assistance, kindly reopen this issue. We are always happy to assist you!

Regards, Ashok K