* Extracting byteStore code to new nio-stream-storage library

synchronoss / nio-multipart

A multipart library that uses nio and asynchronous processing

Apache License 2.0

93 stars 20 forks source link

* Extracting byteStore code to new nio-stream-storage library #2

Closed mcla closed 8 years ago

mcla commented 8 years ago

Integrating with nio-stream-storage library
Renaming instances of byteStore to streamStorage

cjbooms commented 8 years ago

+1 Looks good to me.

The only thing I noticed is that there's a bit of overlap between the DeferredFileStreamStorageFactory provided by nio-stream-storage and the existing DefaultPartBodyStreamStorageFactory. But I think they're different enough to leave as is. The DefaultPartBodyStreamStorageFactory is a specialisation that uses the part number as part of the temporary file's name

cjbooms commented 8 years ago

@Melozzola We'll hold off for a few days before merging this PR in the hopes that you have time to review this change. As the author of this library you may have some valuable insights we haven't considered. :)