search

synchrony / smsn-mode

Emacs client for Semantic Synchrony knowledge graphs
GNU General Public License v3.0
12 stars 6 forks source link

Is develop safe to merge into master right now? #28

Closed JeffreyBenjaminBrown closed 4 years ago

JeffreyBenjaminBrown commented 4 years ago

I just fast-forwarded my smsn-mode repo by 3 years by switching from master to develop. The 2 commits that happened in those three years were one to fix the set-source command (that's what prompted me to update) and another labeled "Add YAML read/write commands". It seems like none of that should be incompatible with the rest of the master branch, right? I suspect merging would be good because as it standsd set-source in master is broken.

joshsh commented 4 years ago

Yes, we could probably just pull develop into master at this point. Anyone using SmSn will be building it from source or starting up your Docker container, not including it in their Maven or Gradle or whatever.

On Wed, Mar 18, 2020 at 9:03 PM Jeffrey Benjamin Brown < notifications@github.com> wrote:

I just fast-forwarded my smsn-mode repo by 3 years by switching from master to develop. The 2 commits that happened in those three years were one to fix the set-source command (that's what prompted me to update) and another labeled "Add YAML read/write commands". It seems like none of that should be incompatible with the rest of the master branch, right? I suspect merging would be good because as it standsd set-source in master is broken.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/synchrony/smsn-mode/issues/28, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAWSBC4HPBADQGHSH4TYADRIGKSVANCNFSM4LO75HWQ .

JeffreyBenjaminBrown commented 4 years ago

Roger, done, thanks!